Skip to content

Commit 7392134

Browse files
committed
media: stv0288: use explicitly signed char
With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as such. Use `s8` and `u8` types here, since that's what surrounding code does. This fixes: drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm' drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop Cc: Mauro Carvalho Chehab <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Jason A. Donenfeld <[email protected]>
1 parent 51c9dae commit 7392134

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/media/dvb-frontends/stv0288.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -440,9 +440,8 @@ static int stv0288_set_frontend(struct dvb_frontend *fe)
440440
struct stv0288_state *state = fe->demodulator_priv;
441441
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
442442

443-
char tm;
444-
unsigned char tda[3];
445-
u8 reg, time_out = 0;
443+
u8 tda[3], reg, time_out = 0;
444+
s8 tm;
446445

447446
dprintk("%s : FE_SET_FRONTEND\n", __func__);
448447

0 commit comments

Comments
 (0)