Skip to content

Commit 741ed08

Browse files
wgottwaltgroeck
authored andcommitted
hwmon: (corsair-psu) update Series 2022 and 2023 support
The series 2022/2023 reports slightly longer vendor/product strings and shares USB ids. Technically the reply size is the USB HID packet size (64 bytes) but all the supported commands do not use more than 8 bytes and replies reporting back strings do not use more then 24 bytes (vendor and product are in one string in the newer devices now). The rest of the reply is always filled with '\0'. Also update comments and documentation accordingly. Signed-off-by: Wilken Gottwalt <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]>
1 parent b54c4b0 commit 741ed08

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

Documentation/hwmon/corsair-psu.rst

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ Supported devices:
1515

1616
Corsair HX850i
1717

18-
Corsair HX1000i (Series 2022 and Series 2023)
18+
Corsair HX1000i (Series 2022 and 2023)
1919

2020
Corsair HX1200i
2121

22-
Corsair HX1500i (Series 2022)
22+
Corsair HX1500i (Series 2022 and 2023)
2323

2424
Corsair RM550i
2525

@@ -80,11 +80,14 @@ temp2_crit Temperature max critical value of psu case
8080
Usage Notes
8181
-----------
8282

83-
It is an USB HID device, so it is auto-detected and supports hot-swapping.
83+
It is an USB HID device, so it is auto-detected, supports hot-swapping and
84+
several devices at once.
8485

8586
Flickering values in the rail voltage levels can be an indicator for a failing
86-
PSU. The driver also provides some additional useful values via debugfs, which
87-
do not fit into the hwmon class.
87+
PSU. Accordingly to the default automatic fan speed plan the fan starts at about
88+
30% of the wattage rating. If this does not happen, a fan failure is likely. The
89+
driver also provides some additional useful values via debugfs, which do not fit
90+
into the hwmon class.
8891

8992
Debugfs entries
9093
---------------

drivers/hwmon/corsair-psu.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,15 @@
4242
* - the driver supports debugfs for values not fitting into the hwmon class
4343
* - not every device class (HXi or RMi) supports all commands
4444
* - if configured wrong the PSU resets or shuts down, often before actually hitting the
45-
* - reported critical temperature
45+
* reported critical temperature
46+
* - new models like HX1500i Series 2023 have changes in the reported vendor and product
47+
* strings, both are slightly longer now, report vendor and product in one string and are
48+
* the same now
4649
*/
4750

4851
#define DRIVER_NAME "corsair-psu"
4952

50-
#define REPLY_SIZE 16 /* max length of a reply to a single command */
53+
#define REPLY_SIZE 24 /* max length of a reply to a single command */
5154
#define CMD_BUFFER_SIZE 64
5255
#define CMD_TIMEOUT_MS 250
5356
#define SECONDS_PER_HOUR (60 * 60)
@@ -880,7 +883,7 @@ static const struct hid_device_id corsairpsu_idtable[] = {
880883
{ HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */
881884
{ HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */
882885
{ HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsair HX1000i Series 2023 */
883-
{ HID_USB_DEVICE(0x1b1c, 0x1c1f) }, /* Corsair HX1500i Series 2022 */
886+
{ HID_USB_DEVICE(0x1b1c, 0x1c1f) }, /* Corsair HX1500i Series 2022 and 2023 */
884887
{ },
885888
};
886889
MODULE_DEVICE_TABLE(hid, corsairpsu_idtable);

0 commit comments

Comments
 (0)