Skip to content

Commit 74478ea

Browse files
Alex Elderdavem330
authored andcommitted
net: ipa: fix QMI structure definition bugs
Building with "W=1" did exactly what it was supposed to do, namely point out some suspicious-looking code to be verified not to contain bugs. Some QMI message structures defined in "ipa_qmi_msg.c" contained some bad field names (duplicating the "elem_size" field instead of defining the "offset" field), almost certainly due to copy/paste errors that weren't obvious in a scan of the code. Fix these bugs. Fixes: 530f921 ("soc: qcom: ipa: AP/modem communications") Signed-off-by: Alex Elder <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 34fe5a1 commit 74478ea

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/ipa/ipa_qmi_msg.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ struct qmi_elem_info ipa_driver_init_complete_rsp_ei[] = {
119119
sizeof_field(struct ipa_driver_init_complete_rsp,
120120
rsp),
121121
.tlv_type = 0x02,
122-
.elem_size = offsetof(struct ipa_driver_init_complete_rsp,
122+
.offset = offsetof(struct ipa_driver_init_complete_rsp,
123123
rsp),
124124
.ei_array = qmi_response_type_v01_ei,
125125
},
@@ -137,7 +137,7 @@ struct qmi_elem_info ipa_init_complete_ind_ei[] = {
137137
sizeof_field(struct ipa_init_complete_ind,
138138
status),
139139
.tlv_type = 0x02,
140-
.elem_size = offsetof(struct ipa_init_complete_ind,
140+
.offset = offsetof(struct ipa_init_complete_ind,
141141
status),
142142
.ei_array = qmi_response_type_v01_ei,
143143
},
@@ -218,7 +218,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = {
218218
sizeof_field(struct ipa_init_modem_driver_req,
219219
platform_type_valid),
220220
.tlv_type = 0x10,
221-
.elem_size = offsetof(struct ipa_init_modem_driver_req,
221+
.offset = offsetof(struct ipa_init_modem_driver_req,
222222
platform_type_valid),
223223
},
224224
{

0 commit comments

Comments
 (0)