thunderbolt: Drop unnecessary read when writing LC command in Ice Lake

westeri · westeri · commit 747125db6dcd · 2019-10-08T12:08:21.000+03:00
The read is not needed as we overwrite the returned value in the next line anyway so drop it. Fixes: 3cdb944 ("thunderbolt: Add support for Intel Ice Lake") Reported-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff --git a/drivers/thunderbolt/nhi_ops.c b/drivers/thunderbolt/nhi_ops.c
@@ -80,7 +80,6 @@ static void icl_nhi_lc_mailbox_cmd(struct tb_nhi *nhi, enum icl_lc_mailbox_cmd c
 {
 	u32 data;
 
-	pci_read_config_dword(nhi->pdev, VS_CAP_19, &data);
 	data = (cmd << VS_CAP_19_CMD_SHIFT) & VS_CAP_19_CMD_MASK;
 	pci_write_config_dword(nhi->pdev, VS_CAP_19, data | VS_CAP_19_VALID);
 }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ static void icl_nhi_lc_mailbox_cmd(struct tb_nhi *nhi, enum icl_lc_mailbox_cmd c`
`80`	`80`	`{`
`81`	`81`	`u32 data;`
`82`	`82`
`83`		`- pci_read_config_dword(nhi->pdev, VS_CAP_19, &data);`
`84`	`83`	`data = (cmd << VS_CAP_19_CMD_SHIFT) & VS_CAP_19_CMD_MASK;`
`85`	`84`	`pci_write_config_dword(nhi->pdev, VS_CAP_19, data \| VS_CAP_19_VALID);`
`86`	`85`	`}`