Skip to content

Commit 7479d26

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: Change name of INTR_STATUS bit 11
INTR_STATUS bit 11 INTR_HC_RESET_CANCEL was probably projected for the MIPI I3C HCI specification version 2 but was not ever implemented. This bit is first time specified in the v1.2 as HC_SEQ_CANCEL_STAT "Host Controller Cancelled Transaction Sequence". Update the definition and debug print of it accordingly. While at it, change DBG() print to dev_dbg(). Reviewed-by: Frank Li <[email protected]> Signed-off-by: Jarkko Nikula <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent a7035a8 commit 7479d26

File tree

1 file changed

+5
-4
lines changed
  • drivers/i3c/master/mipi-i3c-hci

1 file changed

+5
-4
lines changed

drivers/i3c/master/mipi-i3c-hci/core.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
#define INTR_SIGNAL_ENABLE 0x28
7979
#define INTR_FORCE 0x2c
8080
#define INTR_HC_CMD_SEQ_UFLOW_STAT BIT(12) /* Cmd Sequence Underflow */
81-
#define INTR_HC_RESET_CANCEL BIT(11) /* HC Cancelled Reset */
81+
#define INTR_HC_SEQ_CANCEL BIT(11) /* HC Cancelled Transaction Sequence */
8282
#define INTR_HC_INTERNAL_ERR BIT(10) /* HC Internal Error */
8383

8484
#define DAT_SECTION 0x30 /* Device Address Table */
@@ -596,9 +596,10 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id)
596596
if (val)
597597
result = IRQ_HANDLED;
598598

599-
if (val & INTR_HC_RESET_CANCEL) {
600-
DBG("cancelled reset");
601-
val &= ~INTR_HC_RESET_CANCEL;
599+
if (val & INTR_HC_SEQ_CANCEL) {
600+
dev_dbg(&hci->master.dev,
601+
"Host Controller Cancelled Transaction Sequence\n");
602+
val &= ~INTR_HC_SEQ_CANCEL;
602603
}
603604
if (val & INTR_HC_INTERNAL_ERR) {
604605
dev_err(&hci->master.dev, "Host Controller Internal Error\n");

0 commit comments

Comments
 (0)