Skip to content

Commit 751bec0

Browse files
jannauMani-Sadhasivam
authored andcommitted
PCI: apple: Set only available ports up
Iterating over disabled ports results in of_irq_parse_raw() parsing the wrong "interrupt-map" entries, as it takes the status of the node into account. This became apparent after disabling unused PCIe ports in the Apple Silicon device trees instead of deleting them. Switching from for_each_child_of_node_scoped() to for_each_available_child_of_node_scoped() solves this issue. Fixes: 1e33888 ("PCI: apple: Add initial hardware bring-up") Fixes: a0189fd ("arm64: dts: apple: t8103: Disable unused PCIe ports") Signed-off-by: Janne Grunau <[email protected]> Signed-off-by: Alyssa Rosenzweig <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Signed-off-by: Manivannan Sadhasivam <[email protected]> Tested-by: Janne Grunau <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Acked-by: Alyssa Rosenzweig <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net/ Link: https://lore.kernel.org/asahi/[email protected]/ Link: https://patch.msgid.link/[email protected]
1 parent 0af2f6b commit 751bec0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/pcie-apple.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
754754
if (ret)
755755
return ret;
756756

757-
for_each_child_of_node_scoped(dev->of_node, of_port) {
757+
for_each_available_child_of_node_scoped(dev->of_node, of_port) {
758758
ret = apple_pcie_setup_port(pcie, of_port);
759759
if (ret) {
760760
dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret);

0 commit comments

Comments
 (0)