Skip to content

Commit 756d5bf

Browse files
Yang Yingliangbroonie
authored andcommitted
spi: imx: switch to use modern name
Change legacy name master/slave to modern name host/target. No functional changed. Signed-off-by: Yang Yingliang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent d6e1921 commit 756d5bf

File tree

1 file changed

+57
-57
lines changed

1 file changed

+57
-57
lines changed

drivers/spi/spi-imx.c

Lines changed: 57 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ MODULE_PARM_DESC(polling_limit_us,
5252
/* The maximum bytes that a sdma BD can transfer. */
5353
#define MAX_SDMA_BD_BYTES (1 << 15)
5454
#define MX51_ECSPI_CTRL_MAX_BURST 512
55-
/* The maximum bytes that IMX53_ECSPI can transfer in slave mode.*/
55+
/* The maximum bytes that IMX53_ECSPI can transfer in target mode.*/
5656
#define MX53_MAX_TRANSFER_BYTES 512
5757

5858
enum spi_imx_devtype {
@@ -77,7 +77,7 @@ struct spi_imx_devtype_data {
7777
void (*setup_wml)(struct spi_imx_data *spi_imx);
7878
void (*disable)(struct spi_imx_data *spi_imx);
7979
bool has_dmamode;
80-
bool has_slavemode;
80+
bool has_targetmode;
8181
unsigned int fifo_size;
8282
bool dynamic_burst;
8383
/*
@@ -113,10 +113,10 @@ struct spi_imx_data {
113113
unsigned int dynamic_burst;
114114
bool rx_only;
115115

116-
/* Slave mode */
117-
bool slave_mode;
118-
bool slave_aborted;
119-
unsigned int slave_burst;
116+
/* Target mode */
117+
bool target_mode;
118+
bool target_aborted;
119+
unsigned int target_burst;
120120

121121
/* DMA */
122122
bool usedma;
@@ -240,7 +240,7 @@ static bool spi_imx_can_dma(struct spi_controller *controller, struct spi_device
240240
if (!controller->dma_rx)
241241
return false;
242242

243-
if (spi_imx->slave_mode)
243+
if (spi_imx->target_mode)
244244
return false;
245245

246246
if (transfer->len < spi_imx->devtype_data->fifo_size)
@@ -404,12 +404,12 @@ static void spi_imx_buf_tx_swap(struct spi_imx_data *spi_imx)
404404
writel(val, spi_imx->base + MXC_CSPITXDATA);
405405
}
406406

407-
static void mx53_ecspi_rx_slave(struct spi_imx_data *spi_imx)
407+
static void mx53_ecspi_rx_target(struct spi_imx_data *spi_imx)
408408
{
409409
u32 val = be32_to_cpu(readl(spi_imx->base + MXC_CSPIRXDATA));
410410

411411
if (spi_imx->rx_buf) {
412-
int n_bytes = spi_imx->slave_burst % sizeof(val);
412+
int n_bytes = spi_imx->target_burst % sizeof(val);
413413

414414
if (!n_bytes)
415415
n_bytes = sizeof(val);
@@ -418,13 +418,13 @@ static void mx53_ecspi_rx_slave(struct spi_imx_data *spi_imx)
418418
((u8 *)&val) + sizeof(val) - n_bytes, n_bytes);
419419

420420
spi_imx->rx_buf += n_bytes;
421-
spi_imx->slave_burst -= n_bytes;
421+
spi_imx->target_burst -= n_bytes;
422422
}
423423

424424
spi_imx->remainder -= sizeof(u32);
425425
}
426426

427-
static void mx53_ecspi_tx_slave(struct spi_imx_data *spi_imx)
427+
static void mx53_ecspi_tx_target(struct spi_imx_data *spi_imx)
428428
{
429429
u32 val = 0;
430430
int n_bytes = spi_imx->count % sizeof(val);
@@ -535,8 +535,8 @@ static int mx51_ecspi_prepare_message(struct spi_imx_data *spi_imx,
535535
u32 current_cfg = cfg;
536536
int channel = mx51_ecspi_channel(spi);
537537

538-
/* set Master or Slave mode */
539-
if (spi_imx->slave_mode)
538+
/* set Host or Target mode */
539+
if (spi_imx->target_mode)
540540
ctrl &= ~MX51_ECSPI_CTRL_MODE_MASK;
541541
else
542542
ctrl |= MX51_ECSPI_CTRL_MODE_MASK;
@@ -564,11 +564,11 @@ static int mx51_ecspi_prepare_message(struct spi_imx_data *spi_imx,
564564
writel(testreg, spi_imx->base + MX51_ECSPI_TESTREG);
565565

566566
/*
567-
* eCSPI burst completion by Chip Select signal in Slave mode
567+
* eCSPI burst completion by Chip Select signal in Target mode
568568
* is not functional for imx53 Soc, config SPI burst completed when
569569
* BURST_LENGTH + 1 bits are received
570570
*/
571-
if (spi_imx->slave_mode && is_imx53_ecspi(spi_imx))
571+
if (spi_imx->target_mode && is_imx53_ecspi(spi_imx))
572572
cfg &= ~MX51_ECSPI_CONFIG_SBBCTRL(channel);
573573
else
574574
cfg |= MX51_ECSPI_CONFIG_SBBCTRL(channel);
@@ -655,8 +655,8 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
655655

656656
/* Clear BL field and set the right value */
657657
ctrl &= ~MX51_ECSPI_CTRL_BL_MASK;
658-
if (spi_imx->slave_mode && is_imx53_ecspi(spi_imx))
659-
ctrl |= (spi_imx->slave_burst * 8 - 1)
658+
if (spi_imx->target_mode && is_imx53_ecspi(spi_imx))
659+
ctrl |= (spi_imx->target_burst * 8 - 1)
660660
<< MX51_ECSPI_CTRL_BL_OFFSET;
661661
else {
662662
if (spi_imx->count >= 512)
@@ -721,7 +721,7 @@ static void mx51_ecspi_reset(struct spi_imx_data *spi_imx)
721721
#define MX31_INTREG_RREN (1 << 3)
722722

723723
#define MX31_CSPICTRL_ENABLE (1 << 0)
724-
#define MX31_CSPICTRL_MASTER (1 << 1)
724+
#define MX31_CSPICTRL_HOST (1 << 1)
725725
#define MX31_CSPICTRL_XCH (1 << 2)
726726
#define MX31_CSPICTRL_SMC (1 << 3)
727727
#define MX31_CSPICTRL_POL (1 << 4)
@@ -778,7 +778,7 @@ static int mx31_prepare_message(struct spi_imx_data *spi_imx,
778778
static int mx31_prepare_transfer(struct spi_imx_data *spi_imx,
779779
struct spi_device *spi)
780780
{
781-
unsigned int reg = MX31_CSPICTRL_ENABLE | MX31_CSPICTRL_MASTER;
781+
unsigned int reg = MX31_CSPICTRL_ENABLE | MX31_CSPICTRL_HOST;
782782
unsigned int clk;
783783

784784
reg |= spi_imx_clkdiv_2(spi_imx->spi_clk, spi_imx->spi_bus_clk, &clk) <<
@@ -848,7 +848,7 @@ static void mx31_reset(struct spi_imx_data *spi_imx)
848848
#define MX21_CSPICTRL_SSPOL (1 << 8)
849849
#define MX21_CSPICTRL_XCH (1 << 9)
850850
#define MX21_CSPICTRL_ENABLE (1 << 10)
851-
#define MX21_CSPICTRL_MASTER (1 << 11)
851+
#define MX21_CSPICTRL_HOST (1 << 11)
852852
#define MX21_CSPICTRL_DR_SHIFT 14
853853
#define MX21_CSPICTRL_CS_SHIFT 19
854854

@@ -882,7 +882,7 @@ static int mx21_prepare_message(struct spi_imx_data *spi_imx,
882882
static int mx21_prepare_transfer(struct spi_imx_data *spi_imx,
883883
struct spi_device *spi)
884884
{
885-
unsigned int reg = MX21_CSPICTRL_ENABLE | MX21_CSPICTRL_MASTER;
885+
unsigned int reg = MX21_CSPICTRL_ENABLE | MX21_CSPICTRL_HOST;
886886
unsigned int max = is_imx27_cspi(spi_imx) ? 16 : 18;
887887
unsigned int clk;
888888

@@ -924,7 +924,7 @@ static void mx21_reset(struct spi_imx_data *spi_imx)
924924
#define MX1_CSPICTRL_PHA (1 << 5)
925925
#define MX1_CSPICTRL_XCH (1 << 8)
926926
#define MX1_CSPICTRL_ENABLE (1 << 9)
927-
#define MX1_CSPICTRL_MASTER (1 << 10)
927+
#define MX1_CSPICTRL_HOST (1 << 10)
928928
#define MX1_CSPICTRL_DR_SHIFT 13
929929

930930
static void mx1_intctrl(struct spi_imx_data *spi_imx, int enable)
@@ -957,7 +957,7 @@ static int mx1_prepare_message(struct spi_imx_data *spi_imx,
957957
static int mx1_prepare_transfer(struct spi_imx_data *spi_imx,
958958
struct spi_device *spi)
959959
{
960-
unsigned int reg = MX1_CSPICTRL_ENABLE | MX1_CSPICTRL_MASTER;
960+
unsigned int reg = MX1_CSPICTRL_ENABLE | MX1_CSPICTRL_HOST;
961961
unsigned int clk;
962962

963963
reg |= spi_imx_clkdiv_2(spi_imx->spi_clk, spi_imx->spi_bus_clk, &clk) <<
@@ -996,7 +996,7 @@ static struct spi_imx_devtype_data imx1_cspi_devtype_data = {
996996
.fifo_size = 8,
997997
.has_dmamode = false,
998998
.dynamic_burst = false,
999-
.has_slavemode = false,
999+
.has_targetmode = false,
10001000
.devtype = IMX1_CSPI,
10011001
};
10021002

@@ -1010,7 +1010,7 @@ static struct spi_imx_devtype_data imx21_cspi_devtype_data = {
10101010
.fifo_size = 8,
10111011
.has_dmamode = false,
10121012
.dynamic_burst = false,
1013-
.has_slavemode = false,
1013+
.has_targetmode = false,
10141014
.devtype = IMX21_CSPI,
10151015
};
10161016

@@ -1025,7 +1025,7 @@ static struct spi_imx_devtype_data imx27_cspi_devtype_data = {
10251025
.fifo_size = 8,
10261026
.has_dmamode = false,
10271027
.dynamic_burst = false,
1028-
.has_slavemode = false,
1028+
.has_targetmode = false,
10291029
.devtype = IMX27_CSPI,
10301030
};
10311031

@@ -1039,7 +1039,7 @@ static struct spi_imx_devtype_data imx31_cspi_devtype_data = {
10391039
.fifo_size = 8,
10401040
.has_dmamode = false,
10411041
.dynamic_burst = false,
1042-
.has_slavemode = false,
1042+
.has_targetmode = false,
10431043
.devtype = IMX31_CSPI,
10441044
};
10451045

@@ -1054,7 +1054,7 @@ static struct spi_imx_devtype_data imx35_cspi_devtype_data = {
10541054
.fifo_size = 8,
10551055
.has_dmamode = true,
10561056
.dynamic_burst = false,
1057-
.has_slavemode = false,
1057+
.has_targetmode = false,
10581058
.devtype = IMX35_CSPI,
10591059
};
10601060

@@ -1069,7 +1069,7 @@ static struct spi_imx_devtype_data imx51_ecspi_devtype_data = {
10691069
.fifo_size = 64,
10701070
.has_dmamode = true,
10711071
.dynamic_burst = true,
1072-
.has_slavemode = true,
1072+
.has_targetmode = true,
10731073
.disable = mx51_ecspi_disable,
10741074
.devtype = IMX51_ECSPI,
10751075
};
@@ -1083,7 +1083,7 @@ static struct spi_imx_devtype_data imx53_ecspi_devtype_data = {
10831083
.reset = mx51_ecspi_reset,
10841084
.fifo_size = 64,
10851085
.has_dmamode = true,
1086-
.has_slavemode = true,
1086+
.has_targetmode = true,
10871087
.disable = mx51_ecspi_disable,
10881088
.devtype = IMX53_ECSPI,
10891089
};
@@ -1099,7 +1099,7 @@ static struct spi_imx_devtype_data imx6ul_ecspi_devtype_data = {
10991099
.fifo_size = 64,
11001100
.has_dmamode = true,
11011101
.dynamic_burst = true,
1102-
.has_slavemode = true,
1102+
.has_targetmode = true,
11031103
.tx_glitch_fixed = true,
11041104
.disable = mx51_ecspi_disable,
11051105
.devtype = IMX51_ECSPI,
@@ -1164,7 +1164,7 @@ static void spi_imx_push(struct spi_imx_data *spi_imx)
11641164
spi_imx->txfifo++;
11651165
}
11661166

1167-
if (!spi_imx->slave_mode)
1167+
if (!spi_imx->target_mode)
11681168
spi_imx->devtype_data->trigger(spi_imx);
11691169
}
11701170

@@ -1268,7 +1268,7 @@ static int spi_imx_setupxfer(struct spi_device *spi,
12681268
* words, we have to use multiple word-size bursts, we can't use
12691269
* dynamic_burst in that case.
12701270
*/
1271-
if (spi_imx->devtype_data->dynamic_burst && !spi_imx->slave_mode &&
1271+
if (spi_imx->devtype_data->dynamic_burst && !spi_imx->target_mode &&
12721272
!(spi->mode & SPI_CS_WORD) &&
12731273
(spi_imx->bits_per_word == 8 ||
12741274
spi_imx->bits_per_word == 16 ||
@@ -1300,10 +1300,10 @@ static int spi_imx_setupxfer(struct spi_device *spi,
13001300
spi_imx->rx_only = ((t->tx_buf == NULL)
13011301
|| (t->tx_buf == spi->controller->dummy_tx));
13021302

1303-
if (is_imx53_ecspi(spi_imx) && spi_imx->slave_mode) {
1304-
spi_imx->rx = mx53_ecspi_rx_slave;
1305-
spi_imx->tx = mx53_ecspi_tx_slave;
1306-
spi_imx->slave_burst = t->len;
1303+
if (is_imx53_ecspi(spi_imx) && spi_imx->target_mode) {
1304+
spi_imx->rx = mx53_ecspi_rx_target;
1305+
spi_imx->tx = mx53_ecspi_tx_target;
1306+
spi_imx->target_burst = t->len;
13071307
}
13081308

13091309
spi_imx->devtype_data->prepare_transfer(spi_imx, spi);
@@ -1568,8 +1568,8 @@ static int spi_imx_poll_transfer(struct spi_device *spi,
15681568
return 0;
15691569
}
15701570

1571-
static int spi_imx_pio_transfer_slave(struct spi_device *spi,
1572-
struct spi_transfer *transfer)
1571+
static int spi_imx_pio_transfer_target(struct spi_device *spi,
1572+
struct spi_transfer *transfer)
15731573
{
15741574
struct spi_imx_data *spi_imx = spi_controller_get_devdata(spi->controller);
15751575
int ret = 0;
@@ -1588,22 +1588,22 @@ static int spi_imx_pio_transfer_slave(struct spi_device *spi,
15881588
spi_imx->remainder = 0;
15891589

15901590
reinit_completion(&spi_imx->xfer_done);
1591-
spi_imx->slave_aborted = false;
1591+
spi_imx->target_aborted = false;
15921592

15931593
spi_imx_push(spi_imx);
15941594

15951595
spi_imx->devtype_data->intctrl(spi_imx, MXC_INT_TE | MXC_INT_RDR);
15961596

15971597
if (wait_for_completion_interruptible(&spi_imx->xfer_done) ||
1598-
spi_imx->slave_aborted) {
1598+
spi_imx->target_aborted) {
15991599
dev_dbg(&spi->dev, "interrupted\n");
16001600
ret = -EINTR;
16011601
}
16021602

1603-
/* ecspi has a HW issue when works in Slave mode,
1603+
/* ecspi has a HW issue when works in Target mode,
16041604
* after 64 words writtern to TXFIFO, even TXFIFO becomes empty,
16051605
* ECSPI_TXDATA keeps shift out the last word data,
1606-
* so we have to disable ECSPI when in slave mode after the
1606+
* so we have to disable ECSPI when in target mode after the
16071607
* transfer completes
16081608
*/
16091609
if (spi_imx->devtype_data->disable)
@@ -1626,8 +1626,8 @@ static int spi_imx_transfer_one(struct spi_controller *controller,
16261626
while (spi_imx->devtype_data->rx_available(spi_imx))
16271627
readl(spi_imx->base + MXC_CSPIRXDATA);
16281628

1629-
if (spi_imx->slave_mode)
1630-
return spi_imx_pio_transfer_slave(spi, transfer);
1629+
if (spi_imx->target_mode)
1630+
return spi_imx_pio_transfer_target(spi, transfer);
16311631

16321632
/*
16331633
* If we decided in spi_imx_can_dma() that we want to do a DMA
@@ -1693,11 +1693,11 @@ spi_imx_unprepare_message(struct spi_controller *controller, struct spi_message
16931693
return 0;
16941694
}
16951695

1696-
static int spi_imx_slave_abort(struct spi_controller *controller)
1696+
static int spi_imx_target_abort(struct spi_controller *controller)
16971697
{
16981698
struct spi_imx_data *spi_imx = spi_controller_get_devdata(controller);
16991699

1700-
spi_imx->slave_aborted = true;
1700+
spi_imx->target_aborted = true;
17011701
complete(&spi_imx->xfer_done);
17021702

17031703
return 0;
@@ -1712,17 +1712,17 @@ static int spi_imx_probe(struct platform_device *pdev)
17121712
int ret, irq, spi_drctl;
17131713
const struct spi_imx_devtype_data *devtype_data =
17141714
of_device_get_match_data(&pdev->dev);
1715-
bool slave_mode;
1715+
bool target_mode;
17161716
u32 val;
17171717

1718-
slave_mode = devtype_data->has_slavemode &&
1719-
of_property_read_bool(np, "spi-slave");
1720-
if (slave_mode)
1721-
controller = spi_alloc_slave(&pdev->dev,
1722-
sizeof(struct spi_imx_data));
1723-
else
1724-
controller = spi_alloc_master(&pdev->dev,
1718+
target_mode = devtype_data->has_targetmode &&
1719+
of_property_read_bool(np, "spi-slave");
1720+
if (target_mode)
1721+
controller = spi_alloc_target(&pdev->dev,
17251722
sizeof(struct spi_imx_data));
1723+
else
1724+
controller = spi_alloc_host(&pdev->dev,
1725+
sizeof(struct spi_imx_data));
17261726
if (!controller)
17271727
return -ENOMEM;
17281728

@@ -1741,7 +1741,7 @@ static int spi_imx_probe(struct platform_device *pdev)
17411741
spi_imx = spi_controller_get_devdata(controller);
17421742
spi_imx->controller = controller;
17431743
spi_imx->dev = &pdev->dev;
1744-
spi_imx->slave_mode = slave_mode;
1744+
spi_imx->target_mode = target_mode;
17451745

17461746
spi_imx->devtype_data = devtype_data;
17471747

@@ -1761,7 +1761,7 @@ static int spi_imx_probe(struct platform_device *pdev)
17611761
controller->cleanup = spi_imx_cleanup;
17621762
controller->prepare_message = spi_imx_prepare_message;
17631763
controller->unprepare_message = spi_imx_unprepare_message;
1764-
controller->slave_abort = spi_imx_slave_abort;
1764+
controller->target_abort = spi_imx_target_abort;
17651765
controller->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_NO_CS |
17661766
SPI_MOSI_IDLE_LOW;
17671767

0 commit comments

Comments
 (0)