drm/amdkfd: Fix memory leakage

BoardzMaster · alexdeucher · commit 75818afff631 · 2022-11-29T11:03:39.000-05:00
This patch fixes potential memory leakage and seg fault in _gpuvm_import_dmabuf() function Fixes: d4ec4bd ("drm/amdkfd: Allow access for mmapping KFD BOs") Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -2204,7 +2204,7 @@ int amdgpu_amdkfd_gpuvm_import_dmabuf(struct amdgpu_device *adev,
 
 	ret = drm_vma_node_allow(&obj->vma_node, drm_priv);
 	if (ret) {
-		kfree(mem);
+		kfree(*mem);
 		return ret;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2204,7 +2204,7 @@ int amdgpu_amdkfd_gpuvm_import_dmabuf(struct amdgpu_device *adev,`
`2204`	`2204`
`2205`	`2205`	`ret = drm_vma_node_allow(&obj->vma_node, drm_priv);`
`2206`	`2206`	`if (ret) {`
`2207`		`- kfree(mem);`
	`2207`	`+ kfree(*mem);`
`2208`	`2208`	`return ret;`
`2209`	`2209`	`}`
`2210`	`2210`