Skip to content

Commit 75a50c4

Browse files
Paolo Abenidavem330
authored andcommitted
kselftest: rtnetlink: fix ip route command typo
The blamed commit below introduced a typo causing 'gretap' test-case failures: ./rtnetlink.sh -t kci_test_gretap -v COMMAND: ip link add name test-dummy0 type dummy COMMAND: ip link set test-dummy0 up COMMAND: ip netns add testns COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:' COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200 COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24 COMMAND: ip -netns testns link set dev gretap00 ups Error: either "dev" is duplicate, or "ups" is a garbage. COMMAND: ip -netns testns link del gretap00 COMMAND: ip -netns testns link add dev gretap00 type gretap external COMMAND: ip -netns testns link del gretap00 FAIL: gretap Fix it by using the correct keyword. Fixes: 9c2a19f ("kselftest: rtnetlink.sh: add verbose flag") Signed-off-by: Paolo Abeni <[email protected]> Reviewed-by: Hangbin Liu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d565fa4 commit 75a50c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/net/rtnetlink.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,7 @@ kci_test_gretap()
859859

860860

861861
run_cmd ip -netns "$testns" addr add dev "$DEV_NS" 10.1.1.100/24
862-
run_cmd ip -netns "$testns" link set dev $DEV_NS ups
862+
run_cmd ip -netns "$testns" link set dev $DEV_NS up
863863
run_cmd ip -netns "$testns" link del "$DEV_NS"
864864

865865
# test external mode

0 commit comments

Comments
 (0)