You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revert "ARM: dts: armada-38x: Fix compatible string for gpios"
This reverts commit c4de466, which causes
a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work,
ending up in the DSA switch being non-functional.
The blamed commit is incorrect in the first place:
If compatible = "marvell,armadaxp-gpio", the second (address, size) pair
of the reg property must to point to the per-CPU interrupt registers
<0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers
<0x181c0 0x08> / <0x181c8 0x08>.
But even fixing that leaves the GPIO interrupts broken on the Omnia.
Furthermore:
Commit 5f79c65 explains very well, why the gpio-mvebu driver does not
work reliably with per-CPU interrupts.
Commit 988c8c0 deprecates compatible = marvell,armadaxp-gpio for this
reason.
Fixes: c4de466 ("ARM: dts: armada-38x: Fix compatible string for gpios")
Reported-by: Klaus Kudielka <[email protected]>
Link: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Klaus Kudielka <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Gregory CLEMENT <[email protected]>
0 commit comments