scsi: ibmvscsi_tgt: Remove unneeded variable rc

Saurav-Girepunje · martinkpetersen · commit 75d886a99384 · 2019-11-21T20:47:17.000-05:00
Variable rc is not modified in ibmvscsis_srp_i_logout function. So remove unneeded variable rc. Issue found using coccicheck tool. Link: https://lore.kernel.org/r/20191101120407.GA9369@saurav Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -2354,7 +2354,6 @@ static long ibmvscsis_srp_i_logout(struct scsi_info *vscsi,
 {
 	struct iu_entry *iue = cmd->iue;
 	struct srp_i_logout *log_out = &vio_iu(iue)->srp.i_logout;
-	long rc = ADAPT_SUCCESS;
 
 	if ((vscsi->debit > 0) || !list_empty(&vscsi->schedule_q) ||
 	    !list_empty(&vscsi->waiting_rsp)) {
@@ -2370,7 +2369,7 @@ static long ibmvscsis_srp_i_logout(struct scsi_info *vscsi,
 		ibmvscsis_post_disconnect(vscsi, WAIT_IDLE, 0);
 	}
 
-	return rc;
+	return ADAPT_SUCCESS;
 }
 
 /* Called with intr lock held */

Original file line number	Diff line number	Diff line change
`@@ -2354,7 +2354,6 @@ static long ibmvscsis_srp_i_logout(struct scsi_info *vscsi,`
`2354`	`2354`	`{`
`2355`	`2355`	`struct iu_entry *iue = cmd->iue;`
`2356`	`2356`	`struct srp_i_logout *log_out = &vio_iu(iue)->srp.i_logout;`
`2357`		`- long rc = ADAPT_SUCCESS;`
`2358`	`2357`
`2359`	`2358`	`if ((vscsi->debit > 0) \|\| !list_empty(&vscsi->schedule_q) \|\|`
`2360`	`2359`	`!list_empty(&vscsi->waiting_rsp)) {`
`@@ -2370,7 +2369,7 @@ static long ibmvscsis_srp_i_logout(struct scsi_info *vscsi,`
`2370`	`2369`	`ibmvscsis_post_disconnect(vscsi, WAIT_IDLE, 0);`
`2371`	`2370`	`}`
`2372`	`2371`
`2373`		`- return rc;`
	`2372`	`+ return ADAPT_SUCCESS;`
`2374`	`2373`	`}`
`2375`	`2374`
`2376`	`2375`	`/* Called with intr lock held */`