Skip to content

Commit 75e6d7e

Browse files
ssuthiku-amdjoergroedel
authored andcommitted
iommu/amd: Consolidate timeout pre-define to amd_iommu_type.h
To allow inclusion in other files in subsequent patches. Signed-off-by: Suravee Suthikulpanit <[email protected]> Signed-off-by: Vasant Hegde <[email protected]> Reviewed-by: Jason Gunthorpe <[email protected]> Reviewed-by: Jerry Snitselaar <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Joerg Roedel <[email protected]>
1 parent ade4bec commit 75e6d7e

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

drivers/iommu/amd/amd_iommu_types.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,10 @@
451451
#define PD_IOMMUV2_MASK BIT(3) /* domain has gcr3 table */
452452
#define PD_GIOV_MASK BIT(4) /* domain enable GIOV support */
453453

454+
/* Timeout stuff */
455+
#define LOOP_TIMEOUT 100000
456+
#define MMIO_STATUS_TIMEOUT 2000000
457+
454458
extern bool amd_iommu_dump;
455459
#define DUMP_printk(format, arg...) \
456460
do { \

drivers/iommu/amd/init.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@
8383
#define ACPI_DEVFLAG_LINT1 0x80
8484
#define ACPI_DEVFLAG_ATSDIS 0x10000000
8585

86-
#define LOOP_TIMEOUT 2000000
87-
8886
#define IVRS_GET_SBDF_ID(seg, bus, dev, fn) (((seg & 0xffff) << 16) | ((bus & 0xff) << 8) \
8987
| ((dev & 0x1f) << 3) | (fn & 0x7))
9088

@@ -985,14 +983,14 @@ static int iommu_ga_log_enable(struct amd_iommu *iommu)
985983
iommu_feature_enable(iommu, CONTROL_GAINT_EN);
986984
iommu_feature_enable(iommu, CONTROL_GALOG_EN);
987985

988-
for (i = 0; i < LOOP_TIMEOUT; ++i) {
986+
for (i = 0; i < MMIO_STATUS_TIMEOUT; ++i) {
989987
status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
990988
if (status & (MMIO_STATUS_GALOG_RUN_MASK))
991989
break;
992990
udelay(10);
993991
}
994992

995-
if (WARN_ON(i >= LOOP_TIMEOUT))
993+
if (WARN_ON(i >= MMIO_STATUS_TIMEOUT))
996994
return -EINVAL;
997995

998996
return 0;
@@ -2900,14 +2898,14 @@ static void enable_iommus_vapic(void)
29002898
* Need to set and poll check the GALOGRun bit to zero before
29012899
* we can set/ modify GA Log registers safely.
29022900
*/
2903-
for (i = 0; i < LOOP_TIMEOUT; ++i) {
2901+
for (i = 0; i < MMIO_STATUS_TIMEOUT; ++i) {
29042902
status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
29052903
if (!(status & MMIO_STATUS_GALOG_RUN_MASK))
29062904
break;
29072905
udelay(10);
29082906
}
29092907

2910-
if (WARN_ON(i >= LOOP_TIMEOUT))
2908+
if (WARN_ON(i >= MMIO_STATUS_TIMEOUT))
29112909
return;
29122910
}
29132911

drivers/iommu/amd/iommu.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@
4444

4545
#define CMD_SET_TYPE(cmd, t) ((cmd)->data[1] |= ((t) << 28))
4646

47-
#define LOOP_TIMEOUT 100000
48-
4947
/* IO virtual address start page frame number */
5048
#define IOVA_START_PFN (1)
5149
#define IOVA_PFN(addr) ((addr) >> PAGE_SHIFT)

0 commit comments

Comments
 (0)