Skip to content

Commit 75ff8a3

Browse files
Andi Shytiwsakernel
authored andcommitted
i2c: sun6i-p2wi: Use devm_clk_get_enabled()
Replace the pair of functions, devm_clk_get() and clk_prepare_enable(), with a single function devm_clk_get_enabled(). Signed-off-by: Andi Shyti <[email protected]> Reviewed-by: Jernej Skrabec <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 9aaccc6 commit 75ff8a3

File tree

1 file changed

+3
-14
lines changed

1 file changed

+3
-14
lines changed

drivers/i2c/busses/i2c-sun6i-p2wi.c

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -239,15 +239,9 @@ static int p2wi_probe(struct platform_device *pdev)
239239
if (irq < 0)
240240
return irq;
241241

242-
p2wi->clk = devm_clk_get(dev, NULL);
242+
p2wi->clk = devm_clk_get_enabled(dev, NULL);
243243
if (IS_ERR(p2wi->clk)) {
244244
ret = PTR_ERR(p2wi->clk);
245-
dev_err(dev, "failed to retrieve clk: %d\n", ret);
246-
return ret;
247-
}
248-
249-
ret = clk_prepare_enable(p2wi->clk);
250-
if (ret) {
251245
dev_err(dev, "failed to enable clk: %d\n", ret);
252246
return ret;
253247
}
@@ -256,15 +250,14 @@ static int p2wi_probe(struct platform_device *pdev)
256250

257251
p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);
258252
if (IS_ERR(p2wi->rstc)) {
259-
ret = PTR_ERR(p2wi->rstc);
260253
dev_err(dev, "failed to retrieve reset controller: %d\n", ret);
261-
goto err_clk_disable;
254+
return PTR_ERR(p2wi->rstc);
262255
}
263256

264257
ret = reset_control_deassert(p2wi->rstc);
265258
if (ret) {
266259
dev_err(dev, "failed to deassert reset line: %d\n", ret);
267-
goto err_clk_disable;
260+
return ret;
268261
}
269262

270263
init_completion(&p2wi->complete);
@@ -307,9 +300,6 @@ static int p2wi_probe(struct platform_device *pdev)
307300
err_reset_assert:
308301
reset_control_assert(p2wi->rstc);
309302

310-
err_clk_disable:
311-
clk_disable_unprepare(p2wi->clk);
312-
313303
return ret;
314304
}
315305

@@ -318,7 +308,6 @@ static void p2wi_remove(struct platform_device *dev)
318308
struct p2wi *p2wi = platform_get_drvdata(dev);
319309

320310
reset_control_assert(p2wi->rstc);
321-
clk_disable_unprepare(p2wi->clk);
322311
i2c_del_adapter(&p2wi->adapter);
323312
}
324313

0 commit comments

Comments
 (0)