Skip to content

Commit 7608496

Browse files
shimodaybjorn-helgaas
authored andcommitted
misc: pci_endpoint_test: Document policy about adding pci_device_id
Add a comment suggesting that if the endpoint controller Vendor and Device ID are programmable, an existing entry might be usable for testing without having to add an entry to pci_endpoint_test_tbl[]. Link: https://lore.kernel.org/linux-pci/[email protected] Signed-off-by: Yoshihiro Shimoda <[email protected]> Signed-off-by: Krzysztof Wilczyński <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Reviewed-by: Frank Li <[email protected]>
1 parent a50c7de commit 7608496

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/misc/pci_endpoint_test.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,6 +1014,10 @@ static const struct pci_endpoint_test_data rk3588_data = {
10141014
.irq_type = IRQ_TYPE_MSI,
10151015
};
10161016

1017+
/*
1018+
* If the controller's Vendor/Device ID are programmable, you may be able to
1019+
* use one of the existing entries for testing instead of adding a new one.
1020+
*/
10171021
static const struct pci_device_id pci_endpoint_test_tbl[] = {
10181022
{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x),
10191023
.driver_data = (kernel_ulong_t)&default_data,

0 commit comments

Comments
 (0)