Skip to content

Commit 76743b2

Browse files
Tooniismchehab
authored andcommitted
media: camss: camss-video: Don't zero subdev format again after initialization
In an earlier commit, setting the which field of the subdev format struct in video_get_subdev_format was moved to a designated initializer that also zeroes all other fields. However, the memset call that was zeroing the fields earlier was left in place, causing the which field to be cleared after being set in the initializer. Remove the memset call from video_get_subdev_format to avoid clearing the initialized which field. Fixes: ecefa10 ("media: Zero-initialize all structures passed to subdev pad operations") Signed-off-by: Yassine Oudjana <[email protected]> Acked-by: Bryan O'Donoghue <[email protected]> Tested-by: Andrey Konovalov <[email protected]> Signed-off-by: Hans Verkuil <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 14b4bd0 commit 76743b2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/media/platform/qcom/camss/camss-video.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,6 @@ static int video_get_subdev_format(struct camss_video *video,
353353
if (subdev == NULL)
354354
return -EPIPE;
355355

356-
memset(&fmt, 0, sizeof(fmt));
357356
fmt.pad = pad;
358357

359358
ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);

0 commit comments

Comments
 (0)