Skip to content

Commit 76b58d5

Browse files
shramamoorthylag-linaro
authored andcommitted
mfd: tps65219: Remove TPS65219_REG_TI_DEV_ID check
The chipid macro/variable and regmap_read function call is not needed because the TPS65219_REG_TI_DEV_ID register value is not a consistent value across TPS65219 PMIC config versions. Reading from the DEV_ID register without a consistent value to compare it to isn't useful. There isn't a way to verify the match data ID is the same ID read from the DEV_ID device register. 0xF0 isn't a DEV_ID value consistent across TPS65219 NVM configurations. For TPS65215, there is a consistent value in bits 5-0 of the DEV_ID register. However, there are other error checks in place within probe() that apply to both PMICs rather than keeping this isolated check for one PMIC. Signed-off-by: Shree Ramamoorthy <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent 5a004cf commit 76b58d5

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/mfd/tps65219.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ static const struct regmap_irq_chip tps65219_irq_chip = {
221221
static int tps65219_probe(struct i2c_client *client)
222222
{
223223
struct tps65219 *tps;
224-
unsigned int chipid;
225224
bool pwr_button;
226225
int ret;
227226

@@ -246,12 +245,6 @@ static int tps65219_probe(struct i2c_client *client)
246245
if (ret)
247246
return ret;
248247

249-
ret = regmap_read(tps->regmap, TPS65219_REG_TI_DEV_ID, &chipid);
250-
if (ret) {
251-
dev_err(tps->dev, "Failed to read device ID: %d\n", ret);
252-
return ret;
253-
}
254-
255248
ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO,
256249
tps65219_cells, ARRAY_SIZE(tps65219_cells),
257250
NULL, 0, regmap_irq_get_domain(tps->irq_data));

0 commit comments

Comments
 (0)