Skip to content

Commit 76c70cb

Browse files
committed
PM: sleep: core: Rename dev_pm_may_skip_resume()
The name of dev_pm_may_skip_resume() may be easily confused with the power.may_skip_resume flag which is not checked by that function, so rename the former as dev_pm_skip_resume(). No functional impact. Suggested-by: Alan Stern <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]> Acked-by: Alan Stern <[email protected]> Acked-by: Bjorn Helgaas <[email protected]>
1 parent 0fe8a1b commit 76c70cb

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

Documentation/power/pci.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1034,7 +1034,7 @@ device to be left in suspend after system-wide transitions to the working state.
10341034
This flag is checked by the PM core, but the PCI bus type informs the PM core
10351035
which devices may be left in suspend from its perspective (that happens during
10361036
the "noirq" phase of system-wide suspend and analogous transitions) and next it
1037-
uses the dev_pm_may_skip_resume() helper to decide whether or not to return from
1037+
uses the dev_pm_skip_resume() helper to decide whether or not to return from
10381038
pci_pm_resume_noirq() and pci_pm_resume_early() upfront.
10391039

10401040
3.2. Device Runtime Power Management

drivers/acpi/acpi_lpss.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1093,7 +1093,7 @@ static int acpi_lpss_resume_early(struct device *dev)
10931093
if (pdata->dev_desc->resume_from_noirq)
10941094
return 0;
10951095

1096-
if (dev_pm_may_skip_resume(dev))
1096+
if (dev_pm_skip_resume(dev))
10971097
return 0;
10981098

10991099
return acpi_lpss_do_resume_early(dev);
@@ -1105,7 +1105,7 @@ static int acpi_lpss_resume_noirq(struct device *dev)
11051105
int ret;
11061106

11071107
/* Follow acpi_subsys_resume_noirq(). */
1108-
if (dev_pm_may_skip_resume(dev))
1108+
if (dev_pm_skip_resume(dev))
11091109
return 0;
11101110

11111111
ret = pm_generic_resume_noirq(dev);

drivers/acpi/device_pm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,7 @@ EXPORT_SYMBOL_GPL(acpi_subsys_suspend_noirq);
11271127
*/
11281128
static int acpi_subsys_resume_noirq(struct device *dev)
11291129
{
1130-
if (dev_pm_may_skip_resume(dev))
1130+
if (dev_pm_skip_resume(dev))
11311131
return 0;
11321132

11331133
return pm_generic_resume_noirq(dev);
@@ -1145,7 +1145,7 @@ static int acpi_subsys_resume_early(struct device *dev)
11451145
{
11461146
int ret;
11471147

1148-
if (dev_pm_may_skip_resume(dev))
1148+
if (dev_pm_skip_resume(dev))
11491149
return 0;
11501150

11511151
ret = acpi_dev_resume(dev);

drivers/base/power/main.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ static void dpm_watchdog_clear(struct dpm_watchdog *wd)
562562
/*------------------------- Resume routines -------------------------*/
563563

564564
/**
565-
* dev_pm_may_skip_resume - System-wide device resume optimization check.
565+
* dev_pm_skip_resume - System-wide device resume optimization check.
566566
* @dev: Target device.
567567
*
568568
* Return:
@@ -572,7 +572,7 @@ static void dpm_watchdog_clear(struct dpm_watchdog *wd)
572572
* - The logical negation of %power.must_resume otherwise (that is, when the
573573
* transition under way is RESUME).
574574
*/
575-
bool dev_pm_may_skip_resume(struct device *dev)
575+
bool dev_pm_skip_resume(struct device *dev)
576576
{
577577
if (pm_transition.event == PM_EVENT_RESTORE)
578578
return false;
@@ -611,7 +611,7 @@ static int device_resume_noirq(struct device *dev, pm_message_t state, bool asyn
611611
if (!dpm_wait_for_superior(dev, async))
612612
goto Out;
613613

614-
skip_resume = dev_pm_may_skip_resume(dev);
614+
skip_resume = dev_pm_skip_resume(dev);
615615
/*
616616
* If the driver callback is skipped below or by the middle layer
617617
* callback and device_resume_early() also skips the driver callback for
@@ -797,7 +797,7 @@ static int device_resume_early(struct device *dev, pm_message_t state, bool asyn
797797
if (callback)
798798
goto Run;
799799

800-
if (dev_pm_may_skip_resume(dev))
800+
if (dev_pm_skip_resume(dev))
801801
goto Skip;
802802

803803
if (dev->driver && dev->driver->pm) {

drivers/pci/pci-driver.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,7 @@ static int pci_pm_resume_noirq(struct device *dev)
891891
pci_power_t prev_state = pci_dev->current_state;
892892
bool skip_bus_pm = pci_dev->skip_bus_pm;
893893

894-
if (dev_pm_may_skip_resume(dev))
894+
if (dev_pm_skip_resume(dev))
895895
return 0;
896896

897897
/*
@@ -920,7 +920,7 @@ static int pci_pm_resume_noirq(struct device *dev)
920920

921921
static int pci_pm_resume_early(struct device *dev)
922922
{
923-
if (dev_pm_may_skip_resume(dev))
923+
if (dev_pm_skip_resume(dev))
924924
return 0;
925925

926926
return pm_generic_resume_early(dev);

include/linux/pm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -758,7 +758,7 @@ extern int pm_generic_poweroff_late(struct device *dev);
758758
extern int pm_generic_poweroff(struct device *dev);
759759
extern void pm_generic_complete(struct device *dev);
760760

761-
extern bool dev_pm_may_skip_resume(struct device *dev);
761+
extern bool dev_pm_skip_resume(struct device *dev);
762762
extern bool dev_pm_smart_suspend_and_suspended(struct device *dev);
763763

764764
#else /* !CONFIG_PM_SLEEP */

0 commit comments

Comments
 (0)