Skip to content

Commit 76e9f43

Browse files
rddunlapgregkh
authored andcommitted
intel_th: msu: Fix kernel-doc warnings
Correct function comments to prevent kernel-doc warnings found when using "W=1". msu.c:77: warning: Function parameter or member 'msc' not described in 'msc_window' msu.c:122: warning: bad line: msu.c:760: warning: No description found for return value of 'msc_configure' msu.c:1309: warning: Function parameter or member 'nr_pages' not described in 'msc_buffer_alloc' msu.c:1309: warning: Function parameter or member 'nr_wins' not described in 'msc_buffer_alloc' msu.c:1309: warning: Excess function parameter 'size' description in 'msc_buffer_alloc' msu.c:1376: warning: No description found for return value of 'msc_buffer_free_unless_used' msu.c:1444: warning: No description found for return value of 'msc_win_to_user' Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Alexander Shishkin <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 988001c commit 76e9f43

File tree

1 file changed

+10
-2
lines changed
  • drivers/hwtracing/intel_th

1 file changed

+10
-2
lines changed

drivers/hwtracing/intel_th/msu.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ enum lockout_state {
6161
* @lo_lock: lockout state serialization
6262
* @nr_blocks: number of blocks (pages) in this window
6363
* @nr_segs: number of segments in this window (<= @nr_blocks)
64+
* @msc: pointer to the MSC device
6465
* @_sgt: array of block descriptors
6566
* @sgt: array of block descriptors
6667
*/
@@ -119,7 +120,6 @@ struct msc_iter {
119120
* @user_count: number of users of the buffer
120121
* @mmap_count: number of mappings
121122
* @buf_mutex: mutex to serialize access to buffer-related bits
122-
123123
* @enabled: MSC is enabled
124124
* @wrap: wrapping is enabled
125125
* @mode: MSC operating mode
@@ -755,6 +755,8 @@ static int msc_win_set_lockout(struct msc_window *win,
755755
* Program storage mode, wrapping, burst length and trace buffer address
756756
* into a given MSC. Then, enable tracing and set msc::enabled.
757757
* The latter is serialized on msc::buf_mutex, so make sure to hold it.
758+
*
759+
* Return: %0 for success or a negative error code otherwise.
758760
*/
759761
static int msc_configure(struct msc *msc)
760762
{
@@ -1291,7 +1293,8 @@ static void msc_buffer_free(struct msc *msc)
12911293
/**
12921294
* msc_buffer_alloc() - allocate a buffer for MSC
12931295
* @msc: MSC device
1294-
* @size: allocation size in bytes
1296+
* @nr_pages: number of pages for each window
1297+
* @nr_wins: number of windows
12951298
*
12961299
* Allocate a storage buffer for MSC, depending on the msc::mode, it will be
12971300
* either done via msc_buffer_contig_alloc() for SINGLE operation mode or
@@ -1370,6 +1373,9 @@ static int msc_buffer_unlocked_free_unless_used(struct msc *msc)
13701373
* @msc: MSC device
13711374
*
13721375
* This is a locked version of msc_buffer_unlocked_free_unless_used().
1376+
*
1377+
* Return: 0 on successful deallocation or if there was no buffer to
1378+
* deallocate, -EBUSY if there are active users.
13731379
*/
13741380
static int msc_buffer_free_unless_used(struct msc *msc)
13751381
{
@@ -1438,6 +1444,8 @@ struct msc_win_to_user_struct {
14381444
* @data: callback's private data
14391445
* @src: source buffer
14401446
* @len: amount of data to copy from the source buffer
1447+
*
1448+
* Return: >= %0 for success or -errno for error.
14411449
*/
14421450
static unsigned long msc_win_to_user(void *data, void *src, size_t len)
14431451
{

0 commit comments

Comments
 (0)