Skip to content

Commit 774d977

Browse files
Tom Rixdavem330
authored andcommitted
net: dsa: b53: check for timeout
clang static analysis reports this problem b53_common.c:1583:13: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage ent.port &= ~BIT(port); ~~~~~~~~ ^ ent is set by a successful call to b53_arl_read(). Unsuccessful calls are caught by an switch statement handling specific returns. b32_arl_read() calls b53_arl_op_wait() which fails with the unhandled -ETIMEDOUT. So add -ETIMEDOUT to the switch statement. Because b53_arl_op_wait() already prints out a message, do not add another one. Fixes: 1da6df8 ("net: dsa: b53: Implement ARL add/del/dump operations") Signed-off-by: Tom Rix <[email protected]> Acked-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f6db909 commit 774d977

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1554,6 +1554,8 @@ static int b53_arl_op(struct b53_device *dev, int op, int port,
15541554
return ret;
15551555

15561556
switch (ret) {
1557+
case -ETIMEDOUT:
1558+
return ret;
15571559
case -ENOSPC:
15581560
dev_dbg(dev->dev, "{%pM,%.4d} no space left in ARL\n",
15591561
addr, vid);

0 commit comments

Comments
 (0)