Skip to content

Commit 77fa900

Browse files
committed
pinctrl: renesas: r8a779g0: Fix CANFD5 suffix
CAN-FD instance 5 has two alternate pin groups: "canfd5" and "canfd5_b". Rename the former to "canfd5_a" to increase uniformity. While at it, remove the unneeded separator. Fixes: ad9bb2f ("pinctrl: renesas: Initial R8A779G0 (R-Car V4H) PFC support") Fixes: 050442a ("pinctrl: renesas: r8a779g0: Add pins, groups and functions") Fixes: c2b4b2c ("pinctrl: renesas: r8a779g0: Add missing CANFD5_B") Signed-off-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/10b22d54086ed11cdfeb0004583029ccf249bdb9.1717754960.git.geert+renesas@glider.be
1 parent cd8894d commit 77fa900

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

drivers/pinctrl/renesas/pfc-r8a779g0.c

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,8 @@
341341
/* IP0SR2 */ /* 0 */ /* 1 */ /* 2 */ /* 3 4 5 6 7 8 9 A B C D E F */
342342
#define IP0SR2_3_0 FM(FXR_TXDA) FM(CANFD1_TX) FM(TPU0TO2_A) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
343343
#define IP0SR2_7_4 FM(FXR_TXENA_N) FM(CANFD1_RX) FM(TPU0TO3_A) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
344-
#define IP0SR2_11_8 FM(RXDA_EXTFXR) FM(CANFD5_TX) FM(IRQ5) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
345-
#define IP0SR2_15_12 FM(CLK_EXTFXR) FM(CANFD5_RX) FM(IRQ4_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
344+
#define IP0SR2_11_8 FM(RXDA_EXTFXR) FM(CANFD5_TX_A) FM(IRQ5) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
345+
#define IP0SR2_15_12 FM(CLK_EXTFXR) FM(CANFD5_RX_A) FM(IRQ4_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
346346
#define IP0SR2_19_16 FM(RXDB_EXTFXR) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
347347
#define IP0SR2_23_20 FM(FXR_TXENB_N) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
348348
#define IP0SR2_27_24 FM(FXR_TXDB) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0)
@@ -896,11 +896,11 @@ static const u16 pinmux_data[] = {
896896
PINMUX_IPSR_GPSR(IP0SR2_7_4, TPU0TO3_A),
897897

898898
PINMUX_IPSR_GPSR(IP0SR2_11_8, RXDA_EXTFXR),
899-
PINMUX_IPSR_GPSR(IP0SR2_11_8, CANFD5_TX),
899+
PINMUX_IPSR_GPSR(IP0SR2_11_8, CANFD5_TX_A),
900900
PINMUX_IPSR_GPSR(IP0SR2_11_8, IRQ5),
901901

902902
PINMUX_IPSR_GPSR(IP0SR2_15_12, CLK_EXTFXR),
903-
PINMUX_IPSR_GPSR(IP0SR2_15_12, CANFD5_RX),
903+
PINMUX_IPSR_GPSR(IP0SR2_15_12, CANFD5_RX_A),
904904
PINMUX_IPSR_GPSR(IP0SR2_15_12, IRQ4_B),
905905

906906
PINMUX_IPSR_GPSR(IP0SR2_19_16, RXDB_EXTFXR),
@@ -1531,15 +1531,14 @@ static const unsigned int canfd4_data_mux[] = {
15311531
};
15321532

15331533
/* - CANFD5 ----------------------------------------------------------------- */
1534-
static const unsigned int canfd5_data_pins[] = {
1535-
/* CANFD5_TX, CANFD5_RX */
1534+
static const unsigned int canfd5_data_a_pins[] = {
1535+
/* CANFD5_TX_A, CANFD5_RX_A */
15361536
RCAR_GP_PIN(2, 2), RCAR_GP_PIN(2, 3),
15371537
};
1538-
static const unsigned int canfd5_data_mux[] = {
1539-
CANFD5_TX_MARK, CANFD5_RX_MARK,
1538+
static const unsigned int canfd5_data_a_mux[] = {
1539+
CANFD5_TX_A_MARK, CANFD5_RX_A_MARK,
15401540
};
15411541

1542-
/* - CANFD5_B ----------------------------------------------------------------- */
15431542
static const unsigned int canfd5_data_b_pins[] = {
15441543
/* CANFD5_TX_B, CANFD5_RX_B */
15451544
RCAR_GP_PIN(1, 8), RCAR_GP_PIN(1, 9),
@@ -2578,8 +2577,8 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
25782577
SH_PFC_PIN_GROUP(canfd2_data),
25792578
SH_PFC_PIN_GROUP(canfd3_data),
25802579
SH_PFC_PIN_GROUP(canfd4_data),
2581-
SH_PFC_PIN_GROUP(canfd5_data), /* suffix might be updated */
2582-
SH_PFC_PIN_GROUP(canfd5_data_b), /* suffix might be updated */
2580+
SH_PFC_PIN_GROUP(canfd5_data_a),
2581+
SH_PFC_PIN_GROUP(canfd5_data_b),
25832582
SH_PFC_PIN_GROUP(canfd6_data),
25842583
SH_PFC_PIN_GROUP(canfd7_data),
25852584
SH_PFC_PIN_GROUP(can_clk),
@@ -2788,8 +2787,7 @@ static const char * const canfd4_groups[] = {
27882787
};
27892788

27902789
static const char * const canfd5_groups[] = {
2791-
/* suffix might be updated */
2792-
"canfd5_data",
2790+
"canfd5_data_a",
27932791
"canfd5_data_b",
27942792
};
27952793

0 commit comments

Comments
 (0)