Skip to content

Commit 7828a3e

Browse files
author
Marc Zyngier
committed
irqchip: Fix probing deferal when using IRQCHIP_PLATFORM_DRIVER helpers
When probing an interrupt controller that is behind a parent, we try to check whether the parent domain is available as an indication that we can actually try to probe. Unfortunately, we are checking this with the firmware node of the about to be probed device, not the parent. This is obviously bound to fail. Instead, use the parent node. Fixes: f8410e6 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros") Reported-by: John Stultz <[email protected]> Tested-by: John Stultz <[email protected]> Signed-off-by: Marc Zyngier <[email protected]>
1 parent 6da4587 commit 7828a3e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irqchip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ int platform_irqchip_probe(struct platform_device *pdev)
5252
* interrupt controller. The actual initialization callback of this
5353
* interrupt controller can check for specific domains as necessary.
5454
*/
55-
if (par_np && !irq_find_matching_host(np, DOMAIN_BUS_ANY))
55+
if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY))
5656
return -EPROBE_DEFER;
5757

5858
return irq_init_cb(np, par_np);

0 commit comments

Comments
 (0)