Skip to content

Commit 7852f73

Browse files
lategoodbyegregkh
authored andcommitted
staging: vchiq_arm: Drop vchiq_arm_init_state
After removal of struct vchiq_2835_state, the init of vchiq_arm_state can be simplified by doing it directly within vchiq_platform_init_state. Signed-off-by: Stefan Wahren <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 4e27661 commit 7852f73

File tree

1 file changed

+9
-18
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+9
-18
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -588,23 +588,6 @@ static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state
588588
return 0;
589589
}
590590

591-
static void
592-
vchiq_arm_init_state(struct vchiq_state *state,
593-
struct vchiq_arm_state *arm_state)
594-
{
595-
if (arm_state) {
596-
rwlock_init(&arm_state->susp_res_lock);
597-
598-
init_completion(&arm_state->ka_evt);
599-
atomic_set(&arm_state->ka_use_count, 0);
600-
atomic_set(&arm_state->ka_use_ack_count, 0);
601-
atomic_set(&arm_state->ka_release_count, 0);
602-
603-
arm_state->state = state;
604-
arm_state->first_connect = 0;
605-
}
606-
}
607-
608591
int
609592
vchiq_platform_init_state(struct vchiq_state *state)
610593
{
@@ -614,7 +597,15 @@ vchiq_platform_init_state(struct vchiq_state *state)
614597
if (!platform_state)
615598
return -ENOMEM;
616599

617-
vchiq_arm_init_state(state, platform_state);
600+
rwlock_init(&platform_state->susp_res_lock);
601+
602+
init_completion(&platform_state->ka_evt);
603+
atomic_set(&platform_state->ka_use_count, 0);
604+
atomic_set(&platform_state->ka_use_ack_count, 0);
605+
atomic_set(&platform_state->ka_release_count, 0);
606+
607+
platform_state->state = state;
608+
618609
state->platform_state = (struct opaque_platform_state *)platform_state;
619610

620611
return 0;

0 commit comments

Comments
 (0)