Skip to content

Commit 785cbc8

Browse files
Mihai Saingregkh
authored andcommitted
tty: atmel_serial: Use devm_platform_ioremap_resource()
Simplify the request port function by using a single call to devm_platform_ioremap_resource(). This will also enhance the printing from /proc/iomem: cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial f0004000-f00041ff : f0004000.flexcom flexcom@f0004000 f8020000-f80201ff : f8020000.flexcom flexcom@f8020000 f0004200-f00043ff : f0004200.serial serial@200 f8020200-f80203ff : f8020200.serial serial@200 fffff200-fffff3ff : fffff200.serial serial@fffff200 Signed-off-by: Mihai Sain <[email protected]> Tested-by: Andrei Simion <[email protected]> Reviewed-by: Hari Prasath Gujulan Elango <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent bcc7ba6 commit 785cbc8

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

drivers/tty/serial/atmel_serial.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2419,17 +2419,11 @@ static void atmel_release_port(struct uart_port *port)
24192419
static int atmel_request_port(struct uart_port *port)
24202420
{
24212421
struct platform_device *mpdev = to_platform_device(port->dev->parent);
2422-
int size = resource_size(mpdev->resource);
2423-
2424-
if (!request_mem_region(port->mapbase, size, "atmel_serial"))
2425-
return -EBUSY;
24262422

24272423
if (port->flags & UPF_IOREMAP) {
2428-
port->membase = ioremap(port->mapbase, size);
2429-
if (port->membase == NULL) {
2430-
release_mem_region(port->mapbase, size);
2431-
return -ENOMEM;
2432-
}
2424+
port->membase = devm_platform_ioremap_resource(mpdev, 0);
2425+
if (IS_ERR(port->membase))
2426+
return PTR_ERR(port->membase);
24332427
}
24342428

24352429
return 0;

0 commit comments

Comments
 (0)