Skip to content

Commit 786bbe5

Browse files
Alex Elderkuba-moo
authored andcommitted
net: ipa: kill FILT_ROUT_CACHE_CFG IPA register
A recent commit defined a few IPA registers used for IPA v5.0+. One of those was a mistake. Although the filter and router caches get *flushed* using a single register, they use distinct registers (ENDP_FILTER_CACHE_CFG and ENDP_ROUTER_CACHE_CFG) for configuration. And although there *exists* a FILT_ROUT_CACHE_CFG register, it is not needed in upstream code. So get rid of definitions related to FILT_ROUT_CACHE_CFG, because they are not needed. Fixes: 8ba5971 ("net: ipa: define IPA v5.0+ registers") Signed-off-by: Alex Elder <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 55c49e5 commit 786bbe5

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

drivers/net/ipa/ipa_reg.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ static bool ipa_reg_id_valid(struct ipa *ipa, enum ipa_reg_id reg_id)
3939
return version <= IPA_VERSION_3_1;
4040

4141
case ENDP_FILTER_ROUTER_HSH_CFG:
42-
return version != IPA_VERSION_4_2;
42+
return version < IPA_VERSION_5_0 &&
43+
version != IPA_VERSION_4_2;
4344

4445
case IRQ_SUSPEND_EN:
4546
case IRQ_SUSPEND_CLR:
@@ -52,7 +53,6 @@ static bool ipa_reg_id_valid(struct ipa *ipa, enum ipa_reg_id reg_id)
5253
case QSB_MAX_WRITES:
5354
case QSB_MAX_READS:
5455
case FILT_ROUT_HASH_EN:
55-
case FILT_ROUT_CACHE_CFG:
5656
case FILT_ROUT_HASH_FLUSH:
5757
case FILT_ROUT_CACHE_FLUSH:
5858
case STATE_AGGR_ACTIVE:

drivers/net/ipa/ipa_reg.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ enum ipa_reg_id {
6161
QSB_MAX_WRITES,
6262
QSB_MAX_READS,
6363
FILT_ROUT_HASH_EN, /* Not IPA v5.0+ */
64-
FILT_ROUT_CACHE_CFG, /* IPA v5.0+ */
6564
FILT_ROUT_HASH_FLUSH, /* Not IPA v5.0+ */
6665
FILT_ROUT_CACHE_FLUSH, /* IPA v5.0+ */
6766
STATE_AGGR_ACTIVE,
@@ -206,14 +205,6 @@ enum ipa_reg_qsb_max_reads_field_id {
206205
GEN_QMB_1_MAX_READS_BEATS, /* IPA v4.0+ */
207206
};
208207

209-
/* FILT_ROUT_CACHE_CFG register */
210-
enum ipa_reg_filt_rout_cache_cfg_field_id {
211-
ROUTER_CACHE_EN,
212-
FILTER_CACHE_EN,
213-
LOW_PRI_HASH_HIT_DISABLE,
214-
LRU_EVICTION_THRESHOLD,
215-
};
216-
217208
/* FILT_ROUT_HASH_EN and FILT_ROUT_HASH_FLUSH registers */
218209
enum ipa_reg_filt_rout_hash_field_id {
219210
IPV6_ROUTER_HASH,

0 commit comments

Comments
 (0)