Skip to content

Commit 78a6ccd

Browse files
Jonathan-Cavitttursulin
authored andcommitted
drm/i915/gt: Ensure memory quiesced before invalidation
All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c ("drm/i915/gen12: Add aux table invalidate for all engines") Requires: a2a4aa0eef3b ("drm/i915: Add the gen12_needs_ccs_aux_inv helper") Signed-off-by: Jonathan Cavitt <[email protected]> Signed-off-by: Andi Shyti <[email protected]> Cc: <[email protected]> # v5.8+ Reviewed-by: Nirmoy Das <[email protected]> Reviewed-by: Andrzej Hajda <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit ad8ebf1) Signed-off-by: Tvrtko Ursulin <[email protected]>
1 parent b2f59e9 commit 78a6ccd

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/gpu/drm/i915/gt/gen8_engine_cs.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,11 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
214214
{
215215
struct intel_engine_cs *engine = rq->engine;
216216

217-
if (mode & EMIT_FLUSH) {
217+
/*
218+
* On Aux CCS platforms the invalidation of the Aux
219+
* table requires quiescing memory traffic beforehand
220+
*/
221+
if (mode & EMIT_FLUSH || gen12_needs_ccs_aux_inv(engine)) {
218222
u32 flags = 0;
219223
int err;
220224
u32 *cs;

0 commit comments

Comments
 (0)