Skip to content

Commit 78a77c9

Browse files
author
Thomas Zimmermann
committed
drm/fb-helper: Clarify use of last_close and output_poll_changed
Clarify documentation in the use of struct drm_driver.last_close and struct drm_mode_config_funcs.output_poll_changed. Those callbacks should not be said for fbdev implementations on top of struct drm_client_funcs. Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Javier Martinez Canillas <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 45b64fd commit 78a77c9

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/gpu/drm/drm_fb_helper.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,13 @@ static DEFINE_MUTEX(kernel_fb_helper_lock);
8989
* It will automatically set up deferred I/O if the driver requires a shadow
9090
* buffer.
9191
*
92-
* At runtime drivers should restore the fbdev console by using
92+
* Existing fbdev implementations should restore the fbdev console by using
9393
* drm_fb_helper_lastclose() as their &drm_driver.lastclose callback.
9494
* They should also notify the fb helper code from updates to the output
9595
* configuration by using drm_fb_helper_output_poll_changed() as their
96-
* &drm_mode_config_funcs.output_poll_changed callback.
96+
* &drm_mode_config_funcs.output_poll_changed callback. New implementations
97+
* of fbdev should be build on top of struct &drm_client_funcs, which handles
98+
* this automatically. Setting the old callbacks should be avoided.
9799
*
98100
* For suspend/resume consider using drm_mode_config_helper_suspend() and
99101
* drm_mode_config_helper_resume() which takes care of fbdev as well.

0 commit comments

Comments
 (0)