Skip to content

Commit 78e9e56

Browse files
committed
kbuild: record symbol versions in *.cmd files
When CONFIG_MODVERSIONS=y, the output from genksyms is saved in separate *.symversions files, and will be used much later when CONFIG_LTO_CLANG=y because it is impossible to update LLVM bit code here. This approach is not robust because: - *.symversions may or may not exist. If *.symversions does not exist, we never know if it is missing for legitimate reason (i.e. no EXPORT_SYMBOL) or something bad has happened (for example, the user accidentally deleted it). Once it occurs, it is not self-healing because *.symversions is generated as a side effect. - stale (i.e. invalid) *.symversions might be picked up if an object is generated in a non-ordinary way, and corresponding *.symversions (, which was generated by old builds) just happen to exist. A more robust approach is to save symbol versions in *.cmd files because: - *.cmd always exists (if the object is generated by if_changed rule or friends). Even if the user accidentally deletes it, it will be regenerated in the next build. - *.cmd is always re-generated when the object is updated. This avoid stale version information being picked up. I will remove *.symversions later. Signed-off-by: Masahiro Yamada <[email protected]> Tested-by: Nicolas Schier <[email protected]> Reviewed-by: Nicolas Schier <[email protected]> Tested-by: Nathan Chancellor <[email protected]>
1 parent e493f47 commit 78e9e56

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

scripts/Makefile.build

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,17 @@ ifdef CONFIG_MODVERSIONS
171171

172172
# Generate .o.symversions files for each .o with exported symbols, and link these
173173
# to the kernel and/or modules at the end.
174+
175+
genksyms_format_rel_crc := [^_]*__crc_\([^ ]*\) = \.; LONG(\([^)]*\)).*
176+
genksyms_format_normal := __crc_\(.*\) = \(.*\);
177+
genksyms_format := $(if $(CONFIG_MODULE_REL_CRCS),$(genksyms_format_rel_crc),$(genksyms_format_normal))
178+
174179
gen_symversions = \
175180
if $(NM) $@ 2>/dev/null | grep -q __ksymtab; then \
176181
$(call cmd_gensymtypes_$(1),$(KBUILD_SYMTYPES),$(@:.o=.symtypes)) \
177182
183+
sed -n 's/$(genksyms_format)/$(pound)SYMVER \1 \2/p' [email protected] \
184+
>> $(dot-target).cmd; \
178185
else \
179186
180187
fi

0 commit comments

Comments
 (0)