Skip to content

Commit 78f2bfa

Browse files
agxlynxeye-dev
authored andcommitted
drm/etnaviv: Warn when GPU doesn't idle fast enough
If the GPU isn't idle after signalling pm_runtime_mark_last_busy() plus waiting for the autosuspend delay there's likely something wrong with the way we check idleness so warn about that. Signed-off-by: Guido Günther <[email protected]> Signed-off-by: Lucas Stach <[email protected]>
1 parent 1a910c1 commit 78f2bfa

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/gpu/drm/etnaviv/etnaviv_gpu.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1839,8 +1839,11 @@ static int etnaviv_gpu_rpm_suspend(struct device *dev)
18391839
mask = gpu->idle_mask & ~(VIVS_HI_IDLE_STATE_FE |
18401840
VIVS_HI_IDLE_STATE_MC);
18411841
idle = gpu_read(gpu, VIVS_HI_IDLE_STATE) & mask;
1842-
if (idle != mask)
1842+
if (idle != mask) {
1843+
dev_warn_ratelimited(dev, "GPU not yet idle, mask: 0x%08x\n",
1844+
idle);
18431845
return -EBUSY;
1846+
}
18441847

18451848
return etnaviv_gpu_hw_suspend(gpu);
18461849
}

0 commit comments

Comments
 (0)