Skip to content

Commit 78ff5a1

Browse files
amboarcminyard
authored andcommitted
ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet
Input Buffer Full Interrupt Enable (IBFIE) is typoed as IBFIF for some registers in the datasheet. Fix the driver to use the sensible acronym. Signed-off-by: Andrew Jeffery <[email protected]> Reviewed-by: Zev Weiss <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
1 parent a5e4236 commit 78ff5a1

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/char/ipmi/kcs_bmc_aspeed.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@
5050
#define LPC_HICR0_LPC2E BIT(6)
5151
#define LPC_HICR0_LPC1E BIT(5)
5252
#define LPC_HICR2 0x008
53-
#define LPC_HICR2_IBFIF3 BIT(3)
54-
#define LPC_HICR2_IBFIF2 BIT(2)
55-
#define LPC_HICR2_IBFIF1 BIT(1)
53+
#define LPC_HICR2_IBFIE3 BIT(3)
54+
#define LPC_HICR2_IBFIE2 BIT(2)
55+
#define LPC_HICR2_IBFIE1 BIT(1)
5656
#define LPC_HICR4 0x010
5757
#define LPC_HICR4_LADR12AS BIT(7)
5858
#define LPC_HICR4_KCSENBL BIT(2)
@@ -83,7 +83,7 @@
8383
#define LPC_STR2 0x040
8484
#define LPC_STR3 0x044
8585
#define LPC_HICRB 0x100
86-
#define LPC_HICRB_IBFIF4 BIT(1)
86+
#define LPC_HICRB_IBFIE4 BIT(1)
8787
#define LPC_HICRB_LPC4E BIT(0)
8888
#define LPC_HICRC 0x104
8989
#define LPC_HICRC_ID4IRQX_MASK GENMASK(7, 4)
@@ -383,20 +383,20 @@ static void aspeed_kcs_irq_mask_update(struct kcs_bmc_device *kcs_bmc, u8 mask,
383383

384384
switch (kcs_bmc->channel) {
385385
case 1:
386-
regmap_update_bits(priv->map, LPC_HICR2, LPC_HICR2_IBFIF1,
387-
enable * LPC_HICR2_IBFIF1);
386+
regmap_update_bits(priv->map, LPC_HICR2, LPC_HICR2_IBFIE1,
387+
enable * LPC_HICR2_IBFIE1);
388388
return;
389389
case 2:
390-
regmap_update_bits(priv->map, LPC_HICR2, LPC_HICR2_IBFIF2,
391-
enable * LPC_HICR2_IBFIF2);
390+
regmap_update_bits(priv->map, LPC_HICR2, LPC_HICR2_IBFIE2,
391+
enable * LPC_HICR2_IBFIE2);
392392
return;
393393
case 3:
394-
regmap_update_bits(priv->map, LPC_HICR2, LPC_HICR2_IBFIF3,
395-
enable * LPC_HICR2_IBFIF3);
394+
regmap_update_bits(priv->map, LPC_HICR2, LPC_HICR2_IBFIE3,
395+
enable * LPC_HICR2_IBFIE3);
396396
return;
397397
case 4:
398-
regmap_update_bits(priv->map, LPC_HICRB, LPC_HICRB_IBFIF4,
399-
enable * LPC_HICRB_IBFIF4);
398+
regmap_update_bits(priv->map, LPC_HICRB, LPC_HICRB_IBFIE4,
399+
enable * LPC_HICRB_IBFIE4);
400400
return;
401401
default:
402402
pr_warn("%s: Unsupported channel: %d", __func__, kcs_bmc->channel);

0 commit comments

Comments
 (0)