Skip to content

Commit 794f877

Browse files
committed
Merge tag 'omap-for-v6.9/dt-warnings-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into soc/late
Update TI clksel clocks to use reg Updates for TI clksel clocks to use the standard reg property instead of the non-standard ti,bit-shift legacy property. There are still lots of TI composite clock related devicetree warnings for missing bindings, and overlapping reg properties. We have grouped some of the TI composite clocks under the clksel clock node, but did not consider the reg property issue. Let's update the existing users before we continue grouping more of the composite clocks. * tag 'omap-for-v6.9/dt-warnings-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap: ARM: dts: omap3: Update clksel clocks to use reg instead of ti,bit-shift ARM: dts: am3: Update clksel clocks to use reg instead of ti,bit-shift clk: ti: Improve clksel clock bit parsing for reg property clk: ti: Handle possible address in the node name Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnd Bergmann <[email protected]>
2 parents d206a76 + 808e653 commit 794f877

16 files changed

+491
-405
lines changed

arch/arm/boot/dts/ti/omap/am33xx-clocks.dtsi

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -108,30 +108,31 @@
108108
compatible = "ti,clksel";
109109
reg = <0x664>;
110110
#clock-cells = <2>;
111-
#address-cells = <0>;
111+
#address-cells = <1>;
112+
#size-cells = <0>;
112113

113-
ehrpwm0_tbclk: clock-ehrpwm0-tbclk {
114+
ehrpwm0_tbclk: clock-ehrpwm0-tbclk@0 {
115+
reg = <0>;
114116
#clock-cells = <0>;
115117
compatible = "ti,gate-clock";
116118
clock-output-names = "ehrpwm0_tbclk";
117119
clocks = <&l4ls_gclk>;
118-
ti,bit-shift = <0>;
119120
};
120121

121-
ehrpwm1_tbclk: clock-ehrpwm1-tbclk {
122+
ehrpwm1_tbclk: clock-ehrpwm1-tbclk@1 {
123+
reg = <1>;
122124
#clock-cells = <0>;
123125
compatible = "ti,gate-clock";
124126
clock-output-names = "ehrpwm1_tbclk";
125127
clocks = <&l4ls_gclk>;
126-
ti,bit-shift = <1>;
127128
};
128129

129-
ehrpwm2_tbclk: clock-ehrpwm2-tbclk {
130+
ehrpwm2_tbclk: clock-ehrpwm2-tbclk@2 {
131+
reg = <2>;
130132
#clock-cells = <0>;
131133
compatible = "ti,gate-clock";
132134
clock-output-names = "ehrpwm2_tbclk";
133135
clocks = <&l4ls_gclk>;
134-
ti,bit-shift = <2>;
135136
};
136137
};
137138
};
@@ -566,17 +567,19 @@
566567
compatible = "ti,clksel";
567568
reg = <0x52c>;
568569
#clock-cells = <2>;
569-
#address-cells = <0>;
570+
#address-cells = <1>;
571+
#size-cells = <0>;
570572

571-
gfx_fclk_clksel_ck: clock-gfx-fclk-clksel {
573+
gfx_fclk_clksel_ck: clock-gfx-fclk-clksel@1 {
574+
reg = <1>;
572575
#clock-cells = <0>;
573576
compatible = "ti,mux-clock";
574577
clock-output-names = "gfx_fclk_clksel_ck";
575578
clocks = <&dpll_core_m4_ck>, <&dpll_per_m2_ck>;
576-
ti,bit-shift = <1>;
577579
};
578580

579-
gfx_fck_div_ck: clock-gfx-fck-div {
581+
gfx_fck_div_ck: clock-gfx-fck-div@0 {
582+
reg = <0>;
580583
#clock-cells = <0>;
581584
compatible = "ti,divider-clock";
582585
clock-output-names = "gfx_fck_div_ck";
@@ -589,30 +592,32 @@
589592
compatible = "ti,clksel";
590593
reg = <0x700>;
591594
#clock-cells = <2>;
592-
#address-cells = <0>;
595+
#address-cells = <1>;
596+
#size-cells = <0>;
593597

594-
sysclkout_pre_ck: clock-sysclkout-pre {
598+
sysclkout_pre_ck: clock-sysclkout-pre@0 {
599+
reg = <0>;
595600
#clock-cells = <0>;
596601
compatible = "ti,mux-clock";
597602
clock-output-names = "sysclkout_pre_ck";
598603
clocks = <&clk_32768_ck>, <&l3_gclk>, <&dpll_ddr_m2_ck>, <&dpll_per_m2_ck>, <&lcd_gclk>;
599604
};
600605

601-
clkout2_div_ck: clock-clkout2-div {
606+
clkout2_div_ck: clock-clkout2-div@3 {
607+
reg = <3>;
602608
#clock-cells = <0>;
603609
compatible = "ti,divider-clock";
604610
clock-output-names = "clkout2_div_ck";
605611
clocks = <&sysclkout_pre_ck>;
606-
ti,bit-shift = <3>;
607612
ti,max-div = <8>;
608613
};
609614

610-
clkout2_ck: clock-clkout2 {
615+
clkout2_ck: clock-clkout2@7 {
616+
reg = <7>;
611617
#clock-cells = <0>;
612618
compatible = "ti,gate-clock";
613619
clock-output-names = "clkout2_ck";
614620
clocks = <&clkout2_div_ck>;
615-
ti,bit-shift = <7>;
616621
};
617622
};
618623
};

arch/arm/boot/dts/ti/omap/am35xx-clocks.dtsi

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,23 @@
6666
compatible = "ti,clksel";
6767
reg = <0xa10>;
6868
#clock-cells = <2>;
69-
#address-cells = <0>;
69+
#address-cells = <1>;
70+
#size-cells = <0>;
7071

71-
ipss_ick: clock-ipss-ick {
72+
ipss_ick: clock-ipss-ick@4 {
73+
reg = <4>;
7274
#clock-cells = <0>;
7375
compatible = "ti,am35xx-interface-clock";
7476
clock-output-names = "ipss_ick";
7577
clocks = <&core_l3_ick>;
76-
ti,bit-shift = <4>;
7778
};
7879

79-
uart4_ick_am35xx: clock-uart4-ick-am35xx {
80+
uart4_ick_am35xx: clock-uart4-ick-am35xx@23 {
81+
reg = <23>;
8082
#clock-cells = <0>;
8183
compatible = "ti,omap3-interface-clock";
8284
clock-output-names = "uart4_ick_am35xx";
8385
clocks = <&core_l4_ick>;
84-
ti,bit-shift = <23>;
8586
};
8687
};
8788

@@ -101,14 +102,15 @@
101102
compatible = "ti,clksel";
102103
reg = <0xa00>;
103104
#clock-cells = <2>;
104-
#address-cells = <0>;
105+
#address-cells = <1>;
106+
#size-cells = <0>;
105107

106-
uart4_fck_am35xx: clock-uart4-fck-am35xx {
108+
uart4_fck_am35xx: clock-uart4-fck-am35xx@23 {
109+
reg = <23>;
107110
#clock-cells = <0>;
108111
compatible = "ti,wait-gate-clock";
109112
clock-output-names = "uart4_fck_am35xx";
110113
clocks = <&core_48m_fck>;
111-
ti,bit-shift = <23>;
112114
};
113115
};
114116
};

arch/arm/boot/dts/ti/omap/omap3430es1-clocks.dtsi

Lines changed: 28 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -50,54 +50,56 @@
5050
compatible = "ti,clksel";
5151
reg = <0xa00>;
5252
#clock-cells = <2>;
53-
#address-cells = <0>;
53+
#address-cells = <1>;
54+
#size-cells = <0>;
5455

55-
d2d_26m_fck: clock-d2d-26m-fck {
56+
d2d_26m_fck: clock-d2d-26m-fck@3 {
57+
reg = <3>;
5658
#clock-cells = <0>;
5759
compatible = "ti,wait-gate-clock";
5860
clock-output-names = "d2d_26m_fck";
5961
clocks = <&sys_ck>;
60-
ti,bit-shift = <3>;
6162
};
6263

63-
fshostusb_fck: clock-fshostusb-fck {
64+
fshostusb_fck: clock-fshostusb-fck@5 {
65+
reg = <5>;
6466
#clock-cells = <0>;
6567
compatible = "ti,wait-gate-clock";
6668
clock-output-names = "fshostusb_fck";
6769
clocks = <&core_48m_fck>;
68-
ti,bit-shift = <5>;
6970
};
7071

71-
ssi_ssr_gate_fck_3430es1: clock-ssi-ssr-gate-fck-3430es1 {
72+
ssi_ssr_gate_fck_3430es1: clock-ssi-ssr-gate-fck-3430es1@0 {
73+
reg = <0>;
7274
#clock-cells = <0>;
7375
compatible = "ti,composite-no-wait-gate-clock";
7476
clock-output-names = "ssi_ssr_gate_fck_3430es1";
7577
clocks = <&corex2_fck>;
76-
ti,bit-shift = <0>;
7778
};
7879
};
7980

8081
clock@a40 {
8182
compatible = "ti,clksel";
8283
reg = <0xa40>;
8384
#clock-cells = <2>;
84-
#address-cells = <0>;
85+
#address-cells = <1>;
86+
#size-cells = <0>;
8587

86-
ssi_ssr_div_fck_3430es1: clock-ssi-ssr-div-fck-3430es1 {
88+
ssi_ssr_div_fck_3430es1: clock-ssi-ssr-div-fck-3430es1@8 {
89+
reg = <8>;
8790
#clock-cells = <0>;
8891
compatible = "ti,composite-divider-clock";
8992
clock-output-names = "ssi_ssr_div_fck_3430es1";
9093
clocks = <&corex2_fck>;
91-
ti,bit-shift = <8>;
9294
ti,dividers = <0>, <1>, <2>, <3>, <4>, <0>, <6>, <0>, <8>;
9395
};
9496

95-
usb_l4_div_ick: clock-usb-l4-div-ick {
97+
usb_l4_div_ick: clock-usb-l4-div-ick@4 {
98+
reg = <4>;
9699
#clock-cells = <0>;
97100
compatible = "ti,composite-divider-clock";
98101
clock-output-names = "usb_l4_div_ick";
99102
clocks = <&l4_ick>;
100-
ti,bit-shift = <4>;
101103
ti,max-div = <1>;
102104
ti,index-starts-at-one;
103105
};
@@ -121,38 +123,39 @@
121123
compatible = "ti,clksel";
122124
reg = <0xa10>;
123125
#clock-cells = <2>;
124-
#address-cells = <0>;
126+
#address-cells = <1>;
127+
#size-cells = <0>;
125128

126-
hsotgusb_ick_3430es1: clock-hsotgusb-ick-3430es1 {
129+
hsotgusb_ick_3430es1: clock-hsotgusb-ick-3430es1@4 {
130+
reg = <4>;
127131
#clock-cells = <0>;
128132
compatible = "ti,omap3-no-wait-interface-clock";
129133
clock-output-names = "hsotgusb_ick_3430es1";
130134
clocks = <&core_l3_ick>;
131-
ti,bit-shift = <4>;
132135
};
133136

134-
fac_ick: clock-fac-ick {
137+
fac_ick: clock-fac-ick@8 {
138+
reg = <8>;
135139
#clock-cells = <0>;
136140
compatible = "ti,omap3-interface-clock";
137141
clock-output-names = "fac_ick";
138142
clocks = <&core_l4_ick>;
139-
ti,bit-shift = <8>;
140143
};
141144

142-
ssi_ick: clock-ssi-ick-3430es1 {
145+
ssi_ick: clock-ssi-ick-3430es1@0 {
146+
reg = <0>;
143147
#clock-cells = <0>;
144148
compatible = "ti,omap3-no-wait-interface-clock";
145149
clock-output-names = "ssi_ick_3430es1";
146150
clocks = <&ssi_l4_ick>;
147-
ti,bit-shift = <0>;
148151
};
149152

150-
usb_l4_gate_ick: clock-usb-l4-gate-ick {
153+
usb_l4_gate_ick: clock-usb-l4-gate-ick@5 {
154+
reg = <5>;
151155
#clock-cells = <0>;
152156
compatible = "ti,composite-interface-clock";
153157
clock-output-names = "usb_l4_gate_ick";
154158
clocks = <&l4_ick>;
155-
ti,bit-shift = <5>;
156159
};
157160
};
158161

@@ -174,14 +177,15 @@
174177
compatible = "ti,clksel";
175178
reg = <0xe00>;
176179
#clock-cells = <2>;
177-
#address-cells = <0>;
180+
#address-cells = <1>;
181+
#size-cells = <0>;
178182

179-
dss1_alwon_fck: clock-dss1-alwon-fck-3430es1 {
183+
dss1_alwon_fck: clock-dss1-alwon-fck-3430es1@0 {
184+
reg = <0>;
180185
#clock-cells = <0>;
181186
compatible = "ti,gate-clock";
182187
clock-output-names = "dss1_alwon_fck_3430es1";
183188
clocks = <&dpll4_m4x2_ck>;
184-
ti,bit-shift = <0>;
185189
ti,set-rate-parent;
186190
};
187191
};

0 commit comments

Comments
 (0)