Skip to content

Commit 795c58e

Browse files
committed
Merge tag 'trace-v6.10-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
Pull tracing fix from Steven Rostedt: "Fix ioctl conflict with memmapped ring buffer ioctl It was reported that the ioctl() number used to update the ring buffer memory mapping conflicted with the TCGETS ioctl causing strace to report: $ strace -e ioctl stty ioctl(0, TCGETS or TRACE_MMAP_IOCTL_GET_READER, {c_iflag=ICRNL|IXON, c_oflag=NL0|CR0|TAB0|BS0|VT0|FF0|OPOST|ONLCR, c_cflag=B38400|CS8|CREAD, c_lflag=ISIG|ICANON|ECHO|ECHOE|ECHOK|IEXTEN|ECHOCTL|ECHOKE, ...}) = 0 Since this ioctl hasn't been in a full release yet, change it from "T", 0x1 to "R" 0x20, and also reserve 0x20-0x2F for future ioctl commands, as some more are being worked on for the future" * tag 'trace-v6.10-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace: tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F
2 parents 8a9c6c4 + 4ecaf7e commit 795c58e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Documentation/userspace-api/ioctl/ioctl-number.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ Code Seq# Include File Comments
186186
'Q' all linux/soundcard.h
187187
'R' 00-1F linux/random.h conflict!
188188
'R' 01 linux/rfkill.h conflict!
189+
'R' 20-2F linux/trace_mmap.h
189190
'R' C0-DF net/bluetooth/rfcomm.h
190191
'R' E0 uapi/linux/fsl_mc.h
191192
'S' all linux/cdrom.h conflict!

include/uapi/linux/trace_mmap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@ struct trace_buffer_meta {
4343
__u64 Reserved2;
4444
};
4545

46-
#define TRACE_MMAP_IOCTL_GET_READER _IO('T', 0x1)
46+
#define TRACE_MMAP_IOCTL_GET_READER _IO('R', 0x20)
4747

4848
#endif /* _TRACE_MMAP_H_ */

0 commit comments

Comments
 (0)