Skip to content

Commit 796a8fa

Browse files
Russell Kingdavem330
authored andcommitted
net: phy: bcm84881: clear settings on link down
Clear the link partner advertisement, speed, duplex and pause when the link goes down, as other phylib drivers do. This avoids the stale link partner, speed and duplex settings being reported via ethtool. Signed-off-by: Russell King <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d97793a commit 796a8fa

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/phy/bcm84881.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,16 +155,16 @@ static int bcm84881_read_status(struct phy_device *phydev)
155155
if (phydev->autoneg == AUTONEG_ENABLE && !phydev->autoneg_complete)
156156
phydev->link = false;
157157

158-
if (!phydev->link)
159-
return 0;
160-
161158
linkmode_zero(phydev->lp_advertising);
162159
phydev->speed = SPEED_UNKNOWN;
163160
phydev->duplex = DUPLEX_UNKNOWN;
164161
phydev->pause = 0;
165162
phydev->asym_pause = 0;
166163
phydev->mdix = 0;
167164

165+
if (!phydev->link)
166+
return 0;
167+
168168
if (phydev->autoneg_complete) {
169169
val = genphy_c45_read_lpa(phydev);
170170
if (val < 0)

0 commit comments

Comments
 (0)