Skip to content

Commit 79a7482

Browse files
chelsiocudbgmartinkpetersen
authored andcommitted
scsi: csiostor: Add module softdep on cxgb4
Both cxgb4 and csiostor drivers run on their own independent Physical Function. But when cxgb4 and csiostor are both being loaded in parallel via modprobe, there is a race when firmware upgrade is attempted by both the drivers. When the cxgb4 driver initiates the firmware upgrade, it halts the firmware and the chip until upgrade is complete. When the csiostor driver is coming up in parallel, the firmware mailbox communication fails with timeouts and the csiostor driver probe fails. Add a module soft dependency on cxgb4 driver to ensure loading csiostor triggers cxgb4 to load first when available to avoid the firmware upgrade race. Link: https://lore.kernel.org/r/[email protected] Fixes: a3667aa ("[SCSI] csiostor: Chelsio FCoE offload driver") Signed-off-by: Rahul Lakkireddy <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 8e2d81c commit 79a7482

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/scsi/csiostor/csio_init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,3 +1254,4 @@ MODULE_DEVICE_TABLE(pci, csio_pci_tbl);
12541254
MODULE_VERSION(CSIO_DRV_VERSION);
12551255
MODULE_FIRMWARE(FW_FNAME_T5);
12561256
MODULE_FIRMWARE(FW_FNAME_T6);
1257+
MODULE_SOFTDEP("pre: cxgb4");

0 commit comments

Comments
 (0)