Skip to content

Commit 79ef7a4

Browse files
committed
ASoC: Intel: Fix Kconfig for ACPI=n
Merge series from Peter Ujfalusi <[email protected]>: Hi, A recent attempt to fix a missing symbol when CONFIG_SND_SOC_SDCA=m and CONFIG_SND_SOC_ACPI_INTEL_SDCA_QUIRKS=y caused unmet direct dependency warning with randconig. The reason is that SND_SOC_ACPI_INTEL_MATCH is needed to be compilable even if ACPI is not selected, modules have dependency on exported symbols from it. The only solution for these kconfig dependencies seams to be to only select SND_SOC_SDCA if ACPI is enabled from SND_SOC_ACPI_INTEL_SDCA_QUIRKS. Regards, Peter --- Peter Ujfalusi (2): ASoC: Intel: Kconfig: Only select SND_SOC_SDCA if ACPI is enabled ASoC: Intel: Kconfig: Revert make SND_SOC_ACPI_INTEL_MATCH depend on ACPI sound/soc/intel/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.47.0
2 parents ed7bca5 + 4f1636e commit 79ef7a4

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

sound/soc/intel/Kconfig

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,14 @@ if SND_SOC_INTEL_SST_TOPLEVEL || SND_SOC_SOF_INTEL_TOPLEVEL
7070

7171
config SND_SOC_ACPI_INTEL_MATCH
7272
tristate
73-
depends on ACPI
74-
select SND_SOC_ACPI
73+
select SND_SOC_ACPI if ACPI
7574
select SND_SOC_ACPI_INTEL_SDCA_QUIRKS
7675
# this option controls the compilation of ACPI matching tables and
7776
# helpers and is not meant to be selected by the user.
7877

7978
config SND_SOC_ACPI_INTEL_SDCA_QUIRKS
8079
tristate
81-
select SND_SOC_SDCA
80+
select SND_SOC_SDCA if ACPI
8281

8382
endif ## SND_SOC_INTEL_SST_TOPLEVEL || SND_SOC_SOF_INTEL_TOPLEVEL
8483

0 commit comments

Comments
 (0)