Skip to content

Commit 7a53877

Browse files
robherringwilldeacon
authored andcommitted
perf: arm_v7_pmu: Drop obvious comments for enabling/disabling counters and interrupts
The function calls for enabling/disabling counters and interrupts are pretty obvious as to what they are doing, and the comments don't add any additional value. Signed-off-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Anshuman Khandual <[email protected]> Tested-by: James Clark <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 4b0567a commit 7a53877

File tree

1 file changed

+0
-44
lines changed

1 file changed

+0
-44
lines changed

drivers/perf/arm_v7_pmu.c

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -857,14 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event)
857857
return;
858858
}
859859

860-
/*
861-
* Enable counter and interrupt, and set the counter to count
862-
* the event that we're interested in.
863-
*/
864-
865-
/*
866-
* Disable counter
867-
*/
868860
armv7_pmnc_disable_counter(idx);
869861

870862
/*
@@ -875,14 +867,7 @@ static void armv7pmu_enable_event(struct perf_event *event)
875867
if (cpu_pmu->set_event_filter || idx != ARMV7_IDX_CYCLE_COUNTER)
876868
armv7_pmnc_write_evtsel(idx, hwc->config_base);
877869

878-
/*
879-
* Enable interrupt for this counter
880-
*/
881870
armv7_pmnc_enable_intens(idx);
882-
883-
/*
884-
* Enable counter
885-
*/
886871
armv7_pmnc_enable_counter(idx);
887872
}
888873

@@ -898,18 +883,7 @@ static void armv7pmu_disable_event(struct perf_event *event)
898883
return;
899884
}
900885

901-
/*
902-
* Disable counter and interrupt
903-
*/
904-
905-
/*
906-
* Disable counter
907-
*/
908886
armv7_pmnc_disable_counter(idx);
909-
910-
/*
911-
* Disable interrupt for this counter
912-
*/
913887
armv7_pmnc_disable_intens(idx);
914888
}
915889

@@ -1476,12 +1450,6 @@ static void krait_pmu_enable_event(struct perf_event *event)
14761450
struct hw_perf_event *hwc = &event->hw;
14771451
int idx = hwc->idx;
14781452

1479-
/*
1480-
* Enable counter and interrupt, and set the counter to count
1481-
* the event that we're interested in.
1482-
*/
1483-
1484-
/* Disable counter */
14851453
armv7_pmnc_disable_counter(idx);
14861454

14871455
/*
@@ -1494,10 +1462,7 @@ static void krait_pmu_enable_event(struct perf_event *event)
14941462
else
14951463
armv7_pmnc_write_evtsel(idx, hwc->config_base);
14961464

1497-
/* Enable interrupt for this counter */
14981465
armv7_pmnc_enable_intens(idx);
1499-
1500-
/* Enable counter */
15011466
armv7_pmnc_enable_counter(idx);
15021467
}
15031468

@@ -1797,12 +1762,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event)
17971762
struct hw_perf_event *hwc = &event->hw;
17981763
int idx = hwc->idx;
17991764

1800-
/*
1801-
* Enable counter and interrupt, and set the counter to count
1802-
* the event that we're interested in.
1803-
*/
1804-
1805-
/* Disable counter */
18061765
armv7_pmnc_disable_counter(idx);
18071766

18081767
/*
@@ -1815,10 +1774,7 @@ static void scorpion_pmu_enable_event(struct perf_event *event)
18151774
else if (idx != ARMV7_IDX_CYCLE_COUNTER)
18161775
armv7_pmnc_write_evtsel(idx, hwc->config_base);
18171776

1818-
/* Enable interrupt for this counter */
18191777
armv7_pmnc_enable_intens(idx);
1820-
1821-
/* Enable counter */
18221778
armv7_pmnc_enable_counter(idx);
18231779
}
18241780

0 commit comments

Comments
 (0)