Skip to content

Commit 7acc8a2

Browse files
committed
Merge back earlier int340x driver changes for 5.19.
2 parents 7b14580 + be60348 commit 7acc8a2

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

drivers/thermal/intel/int340x_thermal/int3400_thermal.c

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -169,28 +169,25 @@ static int int3400_thermal_run_osc(acpi_handle handle, char *uuid_str, int *enab
169169
acpi_status status;
170170
int result = 0;
171171
struct acpi_osc_context context = {
172-
.uuid_str = NULL,
172+
.uuid_str = uuid_str,
173173
.rev = 1,
174174
.cap.length = 8,
175+
.cap.pointer = buf,
175176
};
176177

177-
context.uuid_str = uuid_str;
178-
179178
buf[OSC_QUERY_DWORD] = 0;
180179
buf[OSC_SUPPORT_DWORD] = *enable;
181180

182-
context.cap.pointer = buf;
183-
184181
status = acpi_run_osc(handle, &context);
185182
if (ACPI_SUCCESS(status)) {
186183
ret = *((u32 *)(context.ret.pointer + 4));
187184
if (ret != *enable)
188185
result = -EPERM;
186+
187+
kfree(context.ret.pointer);
189188
} else
190189
result = -EPERM;
191190

192-
kfree(context.ret.pointer);
193-
194191
return result;
195192
}
196193

@@ -524,21 +521,18 @@ static void int3400_setup_gddv(struct int3400_thermal_priv *priv)
524521

525522
obj = buffer.pointer;
526523
if (obj->type != ACPI_TYPE_PACKAGE || obj->package.count != 1
527-
|| obj->package.elements[0].type != ACPI_TYPE_BUFFER) {
528-
kfree(buffer.pointer);
529-
return;
530-
}
524+
|| obj->package.elements[0].type != ACPI_TYPE_BUFFER)
525+
goto out_free;
531526

532527
priv->data_vault = kmemdup(obj->package.elements[0].buffer.pointer,
533528
obj->package.elements[0].buffer.length,
534529
GFP_KERNEL);
535-
if (!priv->data_vault) {
536-
kfree(buffer.pointer);
537-
return;
538-
}
530+
if (!priv->data_vault)
531+
goto out_free;
539532

540533
bin_attr_data_vault.private = priv->data_vault;
541534
bin_attr_data_vault.size = obj->package.elements[0].buffer.length;
535+
out_free:
542536
kfree(buffer.pointer);
543537
}
544538

0 commit comments

Comments
 (0)