Skip to content

Commit 7b476af

Browse files
drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag
Setting this flag on a scheduler fence prevents pipelining of jobs depending on this fence. In other words we always insert a full CPU round trip before dependent jobs are pushed to the pipeline. Signed-off-by: Christian König <[email protected]> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2113#note_1579296 Reviewed-by: Alex Deucher <[email protected]> Acked-by: Luben Tuikov <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 4190e8b commit 7b476af

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

drivers/gpu/drm/scheduler/sched_entity.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,8 @@ static bool drm_sched_entity_add_dependency_cb(struct drm_sched_entity *entity)
385385
}
386386

387387
s_fence = to_drm_sched_fence(fence);
388-
if (s_fence && s_fence->sched == sched) {
388+
if (s_fence && s_fence->sched == sched &&
389+
!test_bit(DRM_SCHED_FENCE_DONT_PIPELINE, &fence->flags)) {
389390

390391
/*
391392
* Fence is from the same scheduler, only need to wait for

include/drm/gpu_scheduler.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,15 @@
3232

3333
#define MAX_WAIT_SCHED_ENTITY_Q_EMPTY msecs_to_jiffies(1000)
3434

35+
/**
36+
* DRM_SCHED_FENCE_DONT_PIPELINE - Prefent dependency pipelining
37+
*
38+
* Setting this flag on a scheduler fence prevents pipelining of jobs depending
39+
* on this fence. In other words we always insert a full CPU round trip before
40+
* dependen jobs are pushed to the hw queue.
41+
*/
42+
#define DRM_SCHED_FENCE_DONT_PIPELINE DMA_FENCE_FLAG_USER_BITS
43+
3544
struct drm_gem_object;
3645

3746
struct drm_gpu_scheduler;

0 commit comments

Comments
 (0)