Skip to content

Commit 7bb9488

Browse files
Anshuman Khandualctmarinas
authored andcommitted
arm64/sysreg: Rename TRBSR_EL1 fields per auto-gen tools format
This renames TRBSR_EL1 register fields per auto-gen tools format without causing any functional change in the TRBE driver. Cc: Will Deacon <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: Mark Brown <[email protected]> Cc: Rob Herring <[email protected]> Cc: Suzuki K Poulose <[email protected]> Cc: James Morse <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: Anshuman Khandual <[email protected]> Reviewed-by: Suzuki K Poulose <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Catalin Marinas <[email protected]>
1 parent 90cdde8 commit 7bb9488

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

arch/arm64/include/asm/sysreg.h

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -250,19 +250,19 @@
250250
#define TRBPTR_EL1_PTR_SHIFT 0
251251
#define TRBBASER_EL1_BASE_MASK GENMASK_ULL(63, 12)
252252
#define TRBBASER_EL1_BASE_SHIFT 12
253-
#define TRBSR_EC_MASK GENMASK(5, 0)
254-
#define TRBSR_EC_SHIFT 26
255-
#define TRBSR_IRQ BIT(22)
256-
#define TRBSR_TRG BIT(21)
257-
#define TRBSR_WRAP BIT(20)
258-
#define TRBSR_ABORT BIT(18)
259-
#define TRBSR_STOP BIT(17)
260-
#define TRBSR_MSS_MASK GENMASK(15, 0)
261-
#define TRBSR_MSS_SHIFT 0
262-
#define TRBSR_BSC_MASK GENMASK(5, 0)
263-
#define TRBSR_BSC_SHIFT 0
264-
#define TRBSR_FSC_MASK GENMASK(5, 0)
265-
#define TRBSR_FSC_SHIFT 0
253+
#define TRBSR_EL1_EC_MASK GENMASK(31, 26)
254+
#define TRBSR_EL1_EC_SHIFT 26
255+
#define TRBSR_EL1_IRQ BIT(22)
256+
#define TRBSR_EL1_TRG BIT(21)
257+
#define TRBSR_EL1_WRAP BIT(20)
258+
#define TRBSR_EL1_EA BIT(18)
259+
#define TRBSR_EL1_S BIT(17)
260+
#define TRBSR_EL1_MSS_MASK GENMASK(15, 0)
261+
#define TRBSR_EL1_MSS_SHIFT 0
262+
#define TRBSR_EL1_BSC_MASK GENMASK(5, 0)
263+
#define TRBSR_EL1_BSC_SHIFT 0
264+
#define TRBSR_EL1_FSC_MASK GENMASK(5, 0)
265+
#define TRBSR_EL1_FSC_SHIFT 0
266266
#define TRBMAR_SHARE_MASK GENMASK(1, 0)
267267
#define TRBMAR_SHARE_SHIFT 8
268268
#define TRBMAR_OUTER_MASK GENMASK(3, 0)

drivers/hwtracing/coresight/coresight-trbe.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -582,12 +582,12 @@ static void clr_trbe_status(void)
582582
u64 trbsr = read_sysreg_s(SYS_TRBSR_EL1);
583583

584584
WARN_ON(is_trbe_enabled());
585-
trbsr &= ~TRBSR_IRQ;
586-
trbsr &= ~TRBSR_TRG;
587-
trbsr &= ~TRBSR_WRAP;
588-
trbsr &= ~(TRBSR_EC_MASK << TRBSR_EC_SHIFT);
589-
trbsr &= ~(TRBSR_BSC_MASK << TRBSR_BSC_SHIFT);
590-
trbsr &= ~TRBSR_STOP;
585+
trbsr &= ~TRBSR_EL1_IRQ;
586+
trbsr &= ~TRBSR_EL1_TRG;
587+
trbsr &= ~TRBSR_EL1_WRAP;
588+
trbsr &= ~TRBSR_EL1_EC_MASK;
589+
trbsr &= ~TRBSR_EL1_BSC_MASK;
590+
trbsr &= ~TRBSR_EL1_S;
591591
write_sysreg_s(trbsr, SYS_TRBSR_EL1);
592592
}
593593

drivers/hwtracing/coresight/coresight-trbe.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ static inline bool is_trbe_enabled(void)
3939

4040
static inline int get_trbe_ec(u64 trbsr)
4141
{
42-
return (trbsr >> TRBSR_EC_SHIFT) & TRBSR_EC_MASK;
42+
return (trbsr & TRBSR_EL1_EC_MASK) >> TRBSR_EL1_EC_SHIFT;
4343
}
4444

4545
#define TRBE_BSC_NOT_STOPPED 0
@@ -48,40 +48,40 @@ static inline int get_trbe_ec(u64 trbsr)
4848

4949
static inline int get_trbe_bsc(u64 trbsr)
5050
{
51-
return (trbsr >> TRBSR_BSC_SHIFT) & TRBSR_BSC_MASK;
51+
return (trbsr & TRBSR_EL1_BSC_MASK) >> TRBSR_EL1_BSC_SHIFT;
5252
}
5353

5454
static inline void clr_trbe_irq(void)
5555
{
5656
u64 trbsr = read_sysreg_s(SYS_TRBSR_EL1);
5757

58-
trbsr &= ~TRBSR_IRQ;
58+
trbsr &= ~TRBSR_EL1_IRQ;
5959
write_sysreg_s(trbsr, SYS_TRBSR_EL1);
6060
}
6161

6262
static inline bool is_trbe_irq(u64 trbsr)
6363
{
64-
return trbsr & TRBSR_IRQ;
64+
return trbsr & TRBSR_EL1_IRQ;
6565
}
6666

6767
static inline bool is_trbe_trg(u64 trbsr)
6868
{
69-
return trbsr & TRBSR_TRG;
69+
return trbsr & TRBSR_EL1_TRG;
7070
}
7171

7272
static inline bool is_trbe_wrap(u64 trbsr)
7373
{
74-
return trbsr & TRBSR_WRAP;
74+
return trbsr & TRBSR_EL1_WRAP;
7575
}
7676

7777
static inline bool is_trbe_abort(u64 trbsr)
7878
{
79-
return trbsr & TRBSR_ABORT;
79+
return trbsr & TRBSR_EL1_EA;
8080
}
8181

8282
static inline bool is_trbe_running(u64 trbsr)
8383
{
84-
return !(trbsr & TRBSR_STOP);
84+
return !(trbsr & TRBSR_EL1_S);
8585
}
8686

8787
#define TRBE_TRIG_MODE_STOP 0

0 commit comments

Comments
 (0)