Skip to content

Commit 7c15430

Browse files
lenbKalle Valo
authored andcommitted
wifi: ath11k: allow system suspend to survive ath11k
When ath11k runs into internal errors upon suspend, it returns an error code to pci_pm_suspend, which aborts the entire system suspend. The driver should not abort system suspend, but should keep its internal errors to itself, and allow the system to suspend. Otherwise, a user can suspend a laptop by closing the lid and sealing it into a case, assuming that is will suspend, rather than heating up and draining the battery when in transit. In practice, the ath11k device seems to have plenty of transient errors, and subsequent suspend cycles after this failure often succeed. https://bugzilla.kernel.org/show_bug.cgi?id=216968 Fixes: d1b0c33 ("ath11k: implement suspend for QCA6390 PCI devices") Signed-off-by: Len Brown <[email protected]> Cc: [email protected] Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 5b7c4ca commit 7c15430

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/ath/ath11k

1 file changed

+1
-1
lines changed

drivers/net/wireless/ath/ath11k/pci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ static __maybe_unused int ath11k_pci_pm_suspend(struct device *dev)
981981
if (ret)
982982
ath11k_warn(ab, "failed to suspend core: %d\n", ret);
983983

984-
return ret;
984+
return 0;
985985
}
986986

987987
static __maybe_unused int ath11k_pci_pm_resume(struct device *dev)

0 commit comments

Comments
 (0)