virtiofs: use strscpy for copying the queue name

Miklos Szeredi · Miklos Szeredi · commit 7c594bbd2de9 · 2021-11-02T11:08:19.000+01:00
Always null terminate fsvq->name. Reported-by: kernel test robot <lkp@intel.com> Fixes: b43b7e8 ("virtiofs: provide a helper function for virtqueue initialization") Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
@@ -649,7 +649,7 @@ static void virtio_fs_vq_done(struct virtqueue *vq)
 static void virtio_fs_init_vq(struct virtio_fs_vq *fsvq, char *name,
 			      int vq_type)
 {
-	strncpy(fsvq->name, name, VQ_NAME_LEN);
+	strscpy(fsvq->name, name, VQ_NAME_LEN);
 	spin_lock_init(&fsvq->lock);
 	INIT_LIST_HEAD(&fsvq->queued_reqs);
 	INIT_LIST_HEAD(&fsvq->end_reqs);

Original file line number	Diff line number	Diff line change
`@@ -649,7 +649,7 @@ static void virtio_fs_vq_done(struct virtqueue *vq)`
`649`	`649`	`static void virtio_fs_init_vq(struct virtio_fs_vq fsvq, char name,`
`650`	`650`	`int vq_type)`
`651`	`651`	`{`
`652`		`- strncpy(fsvq->name, name, VQ_NAME_LEN);`
	`652`	`+ strscpy(fsvq->name, name, VQ_NAME_LEN);`
`653`	`653`	`spin_lock_init(&fsvq->lock);`
`654`	`654`	`INIT_LIST_HEAD(&fsvq->queued_reqs);`
`655`	`655`	`INIT_LIST_HEAD(&fsvq->end_reqs);`