Skip to content

Commit 7c6082b

Browse files
Oleh-Kravchenkopavelmachek
authored andcommitted
leds: mlxreg: Fix possible buffer overflow
Error was detected by PVS-Studio: V512 A call of the 'sprintf' function will lead to overflow of the buffer 'led_data->led_cdev_name'. Acked-by: Jacek Anaszewski <[email protected]> Acked-by: Pavel Machek <[email protected]> Signed-off-by: Oleh Kravchenko <[email protected]> Signed-off-by: Pavel Machek <[email protected]>
1 parent 66c4113 commit 7c6082b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/leds/leds-mlxreg.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ static int mlxreg_led_config(struct mlxreg_led_priv_data *priv)
228228
brightness = LED_OFF;
229229
led_data->base_color = MLXREG_LED_GREEN_SOLID;
230230
}
231-
sprintf(led_data->led_cdev_name, "%s:%s", "mlxreg",
232-
data->label);
231+
snprintf(led_data->led_cdev_name, sizeof(led_data->led_cdev_name),
232+
"mlxreg:%s", data->label);
233233
led_cdev->name = led_data->led_cdev_name;
234234
led_cdev->brightness = brightness;
235235
led_cdev->max_brightness = LED_ON;

0 commit comments

Comments
 (0)