Skip to content

Commit 7d21fcf

Browse files
kawasakimartinkpetersen
authored andcommitted
scsi: mpi3mr: Suppress command reply debug prints
After it receives command reply, mpi3mr driver checks command result. If the result is not zero, it prints out command information. This debug information is confusing since they are printed even when the non-zero result is expected. "Power-on or device reset occurred" is printed for Test Unit Ready command at drive detection. Inquiry failure for unsupported VPD page header is also printed. They are harmless but look like failures. To avoid the confusion, print the command reply debug information only when the module parameter logging_level has value MPI3_DEBUG_SCSI_ERROR= 64, in same manner as mpt3sas driver. Signed-off-by: Shin'ichiro Kawasaki <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Damien Le Moal <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent ecb8c25 commit 7d21fcf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/scsi/mpi3mr/mpi3mr_os.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3265,7 +3265,8 @@ void mpi3mr_process_op_reply_desc(struct mpi3mr_ioc *mrioc,
32653265
}
32663266

32673267
if (scmd->result != (DID_OK << 16) && (scmd->cmnd[0] != ATA_12) &&
3268-
(scmd->cmnd[0] != ATA_16)) {
3268+
(scmd->cmnd[0] != ATA_16) &&
3269+
mrioc->logging_level & MPI3_DEBUG_SCSI_ERROR) {
32693270
ioc_info(mrioc, "%s :scmd->result 0x%x\n", __func__,
32703271
scmd->result);
32713272
scsi_print_command(scmd);

0 commit comments

Comments
 (0)