Skip to content

Commit 7d953a0

Browse files
Suzuki K Poulosectmarinas
authored andcommitted
arm64: realm: Use aliased addresses for device DMA to shared buffers
When a device performs DMA to a shared buffer using physical addresses, (without Stage1 translation), the device must use the "{I}PA address" with the top bit set in Realm. This is to make sure that a trusted device will be able to write to shared buffers as well as the protected buffers. Thus, a Realm must always program the full address including the "protection" bit, like AMD SME encryption bits. Enable this by providing arm64 specific dma_addr_{encrypted, canonical} helpers for Realms. Please note that the VMM needs to similarly make sure that the SMMU Stage2 in the Non-secure world is setup accordingly to map IPA at the unprotected alias. Cc: Will Deacon <[email protected]> Cc: Jean-Philippe Brucker <[email protected]> Cc: Robin Murphy <[email protected]> Cc: Steven Price <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Marek Szyprowski <[email protected]> Cc: Tom Lendacky <[email protected]> Cc: Aneesh Kumar K.V <[email protected]> Signed-off-by: Suzuki K Poulose <[email protected]> Reviewed-by: Gavin Shan <[email protected]> Acked-by: Catalin Marinas <[email protected]> Reviewed-by: Robin Murphy <[email protected]> Acked-by: Marek Szyprowski <[email protected]> Fixes: 42be24a ("arm64: Enable memory encrypt for Realms") Acked-by: Will Deacon <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Catalin Marinas <[email protected]>
1 parent b66e2ee commit 7d953a0

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

arch/arm64/include/asm/mem_encrypt.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,15 @@ static inline bool force_dma_unencrypted(struct device *dev)
2121
return is_realm_world();
2222
}
2323

24+
/*
25+
* For Arm CCA guests, canonical addresses are "encrypted", so no changes
26+
* required for dma_addr_encrypted().
27+
* The unencrypted DMA buffers must be accessed via the unprotected IPA,
28+
* "top IPA bit" set.
29+
*/
30+
#define dma_addr_unencrypted(x) ((x) | PROT_NS_SHARED)
31+
32+
/* Clear the "top" IPA bit while converting back */
33+
#define dma_addr_canonical(x) ((x) & ~PROT_NS_SHARED)
34+
2435
#endif /* __ASM_MEM_ENCRYPT_H */

0 commit comments

Comments
 (0)