Skip to content

Commit 7db1068

Browse files
xdarklightsuperna9999
authored andcommitted
ARM: dts: amlogic: meson8b: enable UART RX and TX pull up by default
Some boards have noise on the UART RX line when the UART pins are not connected to another device (such as an USB UART adapter). This can be addressed by using a pull up resistor. Not all boards may provide such a pull up resistor on the PCB so enable the SoC's pull-up on the UART RX and TX pads by default. This matches the default (from u-boot or SoC hardware) state for the pinmux configuration on these pads. Signed-off-by: Martin Blumenstingl <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Neil Armstrong <[email protected]>
1 parent 3fa57cb commit 7db1068

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm/boot/dts/amlogic/meson8b.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@
368368
mux {
369369
groups = "uart_tx_ao_a", "uart_rx_ao_a";
370370
function = "uart_ao";
371-
bias-disable;
371+
bias-pull-up;
372372
};
373373
};
374374

@@ -521,7 +521,7 @@
521521
groups = "uart_tx_b0",
522522
"uart_rx_b0";
523523
function = "uart_b";
524-
bias-disable;
524+
bias-pull-up;
525525
};
526526
};
527527

0 commit comments

Comments
 (0)