Skip to content

Commit 7dc4dbf

Browse files
committed
parisc: Drop locking in pdc console code
No need to have specific locking for console I/O since the PDC functions provide an own locking. Signed-off-by: Helge Deller <[email protected]> Cc: <[email protected]> # 6.1+
1 parent 7e6652c commit 7dc4dbf

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

arch/parisc/kernel/pdc_cons.c

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,37 +12,27 @@
1212
#include <asm/page.h> /* for PAGE0 */
1313
#include <asm/pdc.h> /* for iodc_call() proto and friends */
1414

15-
static DEFINE_SPINLOCK(pdc_console_lock);
16-
1715
static void pdc_console_write(struct console *co, const char *s, unsigned count)
1816
{
1917
int i = 0;
20-
unsigned long flags;
2118

22-
spin_lock_irqsave(&pdc_console_lock, flags);
2319
do {
2420
i += pdc_iodc_print(s + i, count - i);
2521
} while (i < count);
26-
spin_unlock_irqrestore(&pdc_console_lock, flags);
2722
}
2823

2924
#ifdef CONFIG_KGDB
3025
static int kgdb_pdc_read_char(void)
3126
{
32-
int c;
33-
unsigned long flags;
34-
35-
spin_lock_irqsave(&pdc_console_lock, flags);
36-
c = pdc_iodc_getc();
37-
spin_unlock_irqrestore(&pdc_console_lock, flags);
27+
int c = pdc_iodc_getc();
3828

3929
return (c <= 0) ? NO_POLL_CHAR : c;
4030
}
4131

4232
static void kgdb_pdc_write_char(u8 chr)
4333
{
44-
if (PAGE0->mem_cons.cl_class != CL_DUPLEX)
45-
pdc_console_write(NULL, &chr, 1);
34+
/* no need to print char as it's shown on standard console */
35+
/* pdc_iodc_print(&chr, 1); */
4636
}
4737

4838
static struct kgdb_io kgdb_pdc_io_ops = {

0 commit comments

Comments
 (0)