Skip to content

Commit 7ddf005

Browse files
Xu PandaIngo Molnar
authored andcommitted
x86/mce/dev-mcelog: use strscpy() to instead of strncpy()
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Xu Panda <[email protected]> Signed-off-by: Yang Yang <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Reviewed-by: Tony Luck <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent bd4edba commit 7ddf005

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

arch/x86/kernel/cpu/mce/dev-mcelog.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ static ssize_t set_trigger(struct device *s, struct device_attribute *attr,
105105
{
106106
char *p;
107107

108-
strncpy(mce_helper, buf, sizeof(mce_helper));
109-
mce_helper[sizeof(mce_helper)-1] = 0;
108+
strscpy(mce_helper, buf, sizeof(mce_helper));
110109
p = strchr(mce_helper, '\n');
111110

112111
if (p)

0 commit comments

Comments
 (0)