Skip to content

Commit 7de6c3f

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: PMIC: Add comments with DSDT power opregion field names
The DSDTs of CHT devices using the Dollar Cove TI PMIC, all use LDO1 - LDO14 names for the DSDT power opregion field names. Add comments with these fields to make it easier to see which PMIC registers are being set by ACPI code using these. Note that LDO4 is missing and the mapped registers jump from 0x43 to 0x45 to match. This matches with how the fields are declared in the DSDT where LDO4 is skipped too. Note there is no hole in the field addresses, LDO4 is simply just not defined on either side. Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 73d15a7 commit 7de6c3f

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

drivers/acpi/pmic/intel_pmic_chtdc_ti.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,19 @@
2020
#define CHTDC_TI_GPADC 0x5a
2121

2222
static struct pmic_table chtdc_ti_power_table[] = {
23-
{ .address = 0x00, .reg = 0x41 },
24-
{ .address = 0x04, .reg = 0x42 },
25-
{ .address = 0x08, .reg = 0x43 },
26-
{ .address = 0x0c, .reg = 0x45 },
27-
{ .address = 0x10, .reg = 0x46 },
28-
{ .address = 0x14, .reg = 0x47 },
29-
{ .address = 0x18, .reg = 0x48 },
30-
{ .address = 0x1c, .reg = 0x49 },
31-
{ .address = 0x20, .reg = 0x4a },
32-
{ .address = 0x24, .reg = 0x4b },
33-
{ .address = 0x28, .reg = 0x4c },
34-
{ .address = 0x2c, .reg = 0x4d },
35-
{ .address = 0x30, .reg = 0x4e },
23+
{ .address = 0x00, .reg = 0x41 }, /* LDO1 */
24+
{ .address = 0x04, .reg = 0x42 }, /* LDO2 */
25+
{ .address = 0x08, .reg = 0x43 }, /* LDO3 */
26+
{ .address = 0x0c, .reg = 0x45 }, /* LDO5 */
27+
{ .address = 0x10, .reg = 0x46 }, /* LDO6 */
28+
{ .address = 0x14, .reg = 0x47 }, /* LDO7 */
29+
{ .address = 0x18, .reg = 0x48 }, /* LDO8 */
30+
{ .address = 0x1c, .reg = 0x49 }, /* LDO9 */
31+
{ .address = 0x20, .reg = 0x4a }, /* LD10 */
32+
{ .address = 0x24, .reg = 0x4b }, /* LD11 */
33+
{ .address = 0x28, .reg = 0x4c }, /* LD12 */
34+
{ .address = 0x2c, .reg = 0x4d }, /* LD13 */
35+
{ .address = 0x30, .reg = 0x4e }, /* LD14 */
3636
};
3737

3838
static struct pmic_table chtdc_ti_thermal_table[] = {

0 commit comments

Comments
 (0)