Skip to content

Commit 7dee6f5

Browse files
cvubrugiernamjaejeon
authored andcommitted
exfat: reuse exfat_inode_info variable instead of calling EXFAT_I()
Also add a local "struct exfat_inode_info *ei" variable to exfat_truncate() to simplify the code. Signed-off-by: Christophe Vu-Brugier <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
1 parent 8cf0588 commit 7dee6f5

File tree

4 files changed

+17
-18
lines changed

4 files changed

+17
-18
lines changed

fs/exfat/file.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ int __exfat_truncate(struct inode *inode, loff_t new_size)
110110
exfat_set_volume_dirty(sb);
111111

112112
num_clusters_new = EXFAT_B_TO_CLU_ROUND_UP(i_size_read(inode), sbi);
113-
num_clusters_phys =
114-
EXFAT_B_TO_CLU_ROUND_UP(EXFAT_I(inode)->i_size_ondisk, sbi);
113+
num_clusters_phys = EXFAT_B_TO_CLU_ROUND_UP(ei->i_size_ondisk, sbi);
115114

116115
exfat_chain_set(&clu, ei->start_clu, num_clusters_phys, ei->flags);
117116

@@ -228,12 +227,13 @@ void exfat_truncate(struct inode *inode, loff_t size)
228227
{
229228
struct super_block *sb = inode->i_sb;
230229
struct exfat_sb_info *sbi = EXFAT_SB(sb);
230+
struct exfat_inode_info *ei = EXFAT_I(inode);
231231
unsigned int blocksize = i_blocksize(inode);
232232
loff_t aligned_size;
233233
int err;
234234

235235
mutex_lock(&sbi->s_lock);
236-
if (EXFAT_I(inode)->start_clu == 0) {
236+
if (ei->start_clu == 0) {
237237
/*
238238
* Empty start_clu != ~0 (not allocated)
239239
*/
@@ -260,11 +260,11 @@ void exfat_truncate(struct inode *inode, loff_t size)
260260
aligned_size++;
261261
}
262262

263-
if (EXFAT_I(inode)->i_size_ondisk > i_size_read(inode))
264-
EXFAT_I(inode)->i_size_ondisk = aligned_size;
263+
if (ei->i_size_ondisk > i_size_read(inode))
264+
ei->i_size_ondisk = aligned_size;
265265

266-
if (EXFAT_I(inode)->i_size_aligned > i_size_read(inode))
267-
EXFAT_I(inode)->i_size_aligned = aligned_size;
266+
if (ei->i_size_aligned > i_size_read(inode))
267+
ei->i_size_aligned = aligned_size;
268268
mutex_unlock(&sbi->s_lock);
269269
}
270270

fs/exfat/inode.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,9 @@ static int exfat_map_cluster(struct inode *inode, unsigned int clu_offset,
114114
unsigned int local_clu_offset = clu_offset;
115115
unsigned int num_to_be_allocated = 0, num_clusters = 0;
116116

117-
if (EXFAT_I(inode)->i_size_ondisk > 0)
117+
if (ei->i_size_ondisk > 0)
118118
num_clusters =
119-
EXFAT_B_TO_CLU_ROUND_UP(EXFAT_I(inode)->i_size_ondisk,
120-
sbi);
119+
EXFAT_B_TO_CLU_ROUND_UP(ei->i_size_ondisk, sbi);
121120

122121
if (clu_offset >= num_clusters)
123122
num_to_be_allocated = clu_offset - num_clusters + 1;
@@ -416,10 +415,10 @@ static int exfat_write_end(struct file *file, struct address_space *mapping,
416415

417416
err = generic_write_end(file, mapping, pos, len, copied, pagep, fsdata);
418417

419-
if (EXFAT_I(inode)->i_size_aligned < i_size_read(inode)) {
418+
if (ei->i_size_aligned < i_size_read(inode)) {
420419
exfat_fs_error(inode->i_sb,
421420
"invalid size(size(%llu) > aligned(%llu)\n",
422-
i_size_read(inode), EXFAT_I(inode)->i_size_aligned);
421+
i_size_read(inode), ei->i_size_aligned);
423422
return -EIO;
424423
}
425424

fs/exfat/namei.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -395,9 +395,9 @@ static int exfat_find_empty_entry(struct inode *inode,
395395

396396
/* directory inode should be updated in here */
397397
i_size_write(inode, size);
398-
EXFAT_I(inode)->i_size_ondisk += sbi->cluster_size;
399-
EXFAT_I(inode)->i_size_aligned += sbi->cluster_size;
400-
EXFAT_I(inode)->flags = p_dir->flags;
398+
ei->i_size_ondisk += sbi->cluster_size;
399+
ei->i_size_aligned += sbi->cluster_size;
400+
ei->flags = p_dir->flags;
401401
inode->i_blocks += 1 << sbi->sect_per_clus_bits;
402402
}
403403

fs/exfat/super.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -366,9 +366,9 @@ static int exfat_read_root(struct inode *inode)
366366

367367
inode->i_blocks = ((i_size_read(inode) + (sbi->cluster_size - 1))
368368
& ~(sbi->cluster_size - 1)) >> inode->i_blkbits;
369-
EXFAT_I(inode)->i_pos = ((loff_t)sbi->root_dir << 32) | 0xffffffff;
370-
EXFAT_I(inode)->i_size_aligned = i_size_read(inode);
371-
EXFAT_I(inode)->i_size_ondisk = i_size_read(inode);
369+
ei->i_pos = ((loff_t)sbi->root_dir << 32) | 0xffffffff;
370+
ei->i_size_aligned = i_size_read(inode);
371+
ei->i_size_ondisk = i_size_read(inode);
372372

373373
exfat_save_attr(inode, ATTR_SUBDIR);
374374
inode->i_mtime = inode->i_atime = inode->i_ctime = ei->i_crtime =

0 commit comments

Comments
 (0)