Skip to content

Commit 7df2a2a

Browse files
author
Frederic Weisbecker
committed
rcu: Use rcu_segcblist_segempty() instead of open coding it
This makes the code more readable. Reviewed-by: Qiuxu Zhuo <[email protected]> Reviewed-by: Joel Fernandes (Google) <[email protected]> Reviewed-by: Paul E. McKenney <[email protected]> Signed-off-by: Frederic Weisbecker <[email protected]>
1 parent 5f98fd0 commit 7df2a2a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/rcu/rcu_segcblist.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ bool rcu_segcblist_entrain(struct rcu_segcblist *rsclp,
368368
smp_mb(); /* Ensure counts are updated before callback is entrained. */
369369
rhp->next = NULL;
370370
for (i = RCU_NEXT_TAIL; i > RCU_DONE_TAIL; i--)
371-
if (rsclp->tails[i] != rsclp->tails[i - 1])
371+
if (!rcu_segcblist_segempty(rsclp, i))
372372
break;
373373
rcu_segcblist_inc_seglen(rsclp, i);
374374
WRITE_ONCE(*rsclp->tails[i], rhp);
@@ -551,7 +551,7 @@ bool rcu_segcblist_accelerate(struct rcu_segcblist *rsclp, unsigned long seq)
551551
* as their ->gp_seq[] grace-period completion sequence number.
552552
*/
553553
for (i = RCU_NEXT_READY_TAIL; i > RCU_DONE_TAIL; i--)
554-
if (rsclp->tails[i] != rsclp->tails[i - 1] &&
554+
if (!rcu_segcblist_segempty(rsclp, i) &&
555555
ULONG_CMP_LT(rsclp->gp_seq[i], seq))
556556
break;
557557

0 commit comments

Comments
 (0)