Skip to content

Commit 7e1fe5d

Browse files
vijendarmukundabroonie
authored andcommitted
ASoC: SOF: amd: fix for firmware reload failure after playback
Setting ACP ACLK as clock source when ACP enters D0 state causing firmware load failure as mentioned in below scenario. - Load snd_sof_amd_rembrandt - Play or Record audio - Stop audio - Unload snd_sof_amd_rembrandt - Reload snd_sof_amd_rembrandt If acp_clkmux_sel register field is set, then clock source will be set to ACP ACLK when ACP enters D0 state. During stream stop, if there is no active stream is running then acp firmware will set the ACP ACLK value to zero. When driver is reloaded and clock source is selected as ACP ACLK, as ACP ACLK is programmed to zero, firmware loading will fail. For RMB platform, remove the clock mux selection field so that ACP will use internal clock source when ACP enters D0 state. Fixes: 41cb85b ("ASoC: SOF: amd: Add support for Rembrandt plaform.") Reported-by: coolstar <[email protected]> Closes: thesofproject/sof#8137 Signed-off-by: Vijendar Mukunda <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 2b21207 commit 7e1fe5d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

sound/soc/sof/amd/pci-rmb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ static const struct sof_amd_acp_desc rembrandt_chip_info = {
3535
.dsp_intr_base = ACP6X_DSP_SW_INTR_BASE,
3636
.sram_pte_offset = ACP6X_SRAM_PTE_OFFSET,
3737
.hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0,
38-
.acp_clkmux_sel = ACP6X_CLKMUX_SEL,
3938
.fusion_dsp_offset = ACP6X_DSP_FUSION_RUNSTALL,
4039
.probe_reg_offset = ACP6X_FUTURE_REG_ACLK_0,
4140
};

0 commit comments

Comments
 (0)